Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I assume that we are now in code cleanup phase. I use PhpStorm to find possible bugs and problems in the Drupal 8 core. Normally I will not alter code flow. If I find problems in a file, which I will not fix, but find suspicious. I'll mention it in the text here.
And also, this is my first patch to the D8 core. So bare with me if I do something not as expected.
Checked: utility.inc file.
Comment | File | Size | Author |
---|---|---|---|
#4 | drupal_core-code_cleanup_doc_cleanup-1965200-4.patch | 999 bytes | ro-no-lo |
#1 | drupal_core-code_cleanup_doc_cleanup-1965200.patch | 999 bytes | ro-no-lo |
Comments
Comment #1
ro-no-lo CreditAttribution: ro-no-lo commentedComment #3
ro-no-lo CreditAttribution: ro-no-lo commentedDamn I diffed into the wrong direction.
Comment #4
ro-no-lo CreditAttribution: ro-no-lo commentedDid the patch file again.
Comment #5
manarth CreditAttribution: manarth commented+1. The removal of line
$line_safe_var = str_replace("\n", '\n', $var);
looked odd, but the$line_safe_var
variable is not used later in the function.Comment #6
YesCT CreditAttribution: YesCT commentedThis issue was RTBC and passing tests on July 1, the beginning of API freeze.
Comment #7
YesCT CreditAttribution: YesCT commentedComment #8
alexpottCommitted a7a57fa and pushed to 8.x. Thanks!
Comment #9.0
(not verified) CreditAttribution: commentedUpdated issue