H Guys

Converting mail_headers to D8 I noticed that the #ajax property doesn't work on fields of type #number.
The #ajax works perfectly when changed to #textfield

Sorry for the really empty bug report.

CommentFileSizeAuthor
#4 ajax-number-1964098.fail_.patch3.18 KBlarowlan
#4 ajax-number-1964098.pass_.patch4.75 KBlarowlan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Component: ajax system » forms system
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Assigned: Unassigned » larowlan
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented

I have a fix for this, just adding tests. Will continue on Monday.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Assigned: larowlan » Unassigned
Status: Active » Needs review
FileSize
ajax-number-1964098.pass_.patch4.75 KB
ajax-number-1964098.fail_.patch3.18 KB

Tests to verify fail.
Then fix.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Needs review » Reviewed & tested by the community

Nice bugfix

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Needs work

Needs a reroll... patch looks great :)

error: patch failed: core/includes/ajax.inc:566
error: core/includes/ajax.inc: patch does not apply
error: patch failed: core/misc/ajax.js:242
error: core/misc/ajax.js: patch does not apply
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Needs work » Reviewed & tested by the community

Ignore #6 - i'm mad :)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed e784ac7 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.