As per Gabor's request in http://drupal.org/node/148084, this patch will remove all inherit's and reset the LTR values for RTL.

Please review carefully... it is very difficult to test this for sure, while there are sooo many other unfixed bugs in current core RTL themes.

CommentFileSizeAuthor
#4 hook-rtl.png170 bytesGábor Hojtsy
#3 css_remove_inherit_2007112701.patch12.33 KByhager
css_remove_inherit_2007112602.patch11.92 KBhass
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hass’s picture

hass CreditAttribution: hass commented

There was one line in garland style.css that looks not like RTL value.

-  padding: 18px 0 0; /* LTR */
+  padding: 18px 0 0;

I verified this with TopStyle CSS Editor and this means:

top: 18px;
left: 0;
right: 0;

So i think - this is not an RTL value... and i have removed this for now.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

Thanks hass. This is very much appreciated. Now, to verify this patch does the same as the inherit's intended (so they have the same effect as the misused inherits were supposed to be), one only needs to go through all CSS files and check whether these are the same values. Visual theme testing can come after that.

yhager’s picture

yhager CreditAttribution: yhager commented
FileSize
css_remove_inherit_2007112701.patch12.33 KB

Thanks hass, thanks Gabor for your efforts.

I have a part in making the misuse of css inherits, so thanks for helping with the remedy.

I have tested this patch by doing the following:

  • Checking all values by looking into CSS structure.
  • Verifying some using Firebug.
  • Visual testing in most places.

I must add that IMHO, there is no way to make this fix sound. There is no way to make the CSS rules work for all HTML structures. There will always be cases where this will not work. For this reason, I ignored what looks like a non-clean RTL'ing of some rules in Garland, in favor of good visual.

I have done a couple of fixes(forum, color.module), new patch attached. Also added an image (will send by email to Gabor).

Not sure if I should make this RTBC, but on my account it perfectly is.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Needs review » Fixed
FileSize
hook-rtl.png170 bytes

Thanks. The changes looked good to me, so committed. I also noticed you used hook-rtl.png, but the image was not attached, and not in my inbox, so I flipped the hook.png file with Gimp.

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.