Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This behaviour, mostly implemented by mobile devices, is intrusive when typing a username, which can often be uncapitalized and absent from dictionaries.
Maybe there are other forms in the core where we can disable this behaviour?
Here's an example of this implementation: http://davidwalsh.name/disable-autocorrect
Comment | File | Size | Author |
---|---|---|---|
#4 | 1955282-user-account-form-auto-2.patch | 2.13 KB | LewisNyman |
#4 | interdiff.txt | 592 bytes | LewisNyman |
#1 | 1955282-user-account-form-auto-1.patch | 1.58 KB | LewisNyman |
Screen Shot 2013-03-28 at 11.30.03.png | 71.63 KB | LewisNyman |
Comments
Comment #1
LewisNymanHere's a patch, I also added these attributes to the account creation forms.
Comment #2
mgiffordI'm still getting this when I go to E-mail myself a new password. But other than the password reset, it seems to work fine. I just applied this on SimplyTest.me and then navigated there with my iPhone. It's long enough though that folks trying this should consider using a URL shortener.
I do think this is an easy usability improvement.
Comment #3
mgifford#1: 1955282-user-account-form-auto-1.patch queued for re-testing.
Comment #4
LewisNymanI've added these attributes to the request password form.
Comment #5
mcjim CreditAttribution: mcjim commentedIt looks like there are a couple more (but not as important) forms: searching for
'#title' => t('Username'),
brings up node_assign_owner_action_form() in node.module and getSettingsForm() in FileTransfer.php. Perhaps deal with these in a different issue(s)? Didn't find any other forms searching forUSERNAME_MAX_LENGTH
.Otherwise, this looks good: tested on the iOS Simulator and works as expected, with the autocapitalize and autocorrect off. Can probably fire up an Android emulator if anyone thinks that necessary.
Comment #6
mgiffordTested on my iPhone & an Opera Mobile emulator. Both look act as expected.
Comment #7
Dries CreditAttribution: Dries commentedCommitted to 8.x.
Comment #8
xjmThis appears to not have been pushed.
Comment #9
alexpottWasn't pushed... committed ba5c2c4 and pushed to 8.x. Thanks!
Comment #10
amateescu CreditAttribution: amateescu commentedComment #11.0
(not verified) CreditAttribution: commentedAdded example