Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#9 | 1946444-convert-path-confirm-iface-9.patch | 4.58 KB | kim.pepper |
#9 | interdiff.txt | 969 bytes | kim.pepper |
#6 | 1946444-convert-path-confirm-iface-6.patch | 4.58 KB | kim.pepper |
#6 | interdiff.txt | 3.11 KB | kim.pepper |
#2 | 1946444-convert-path-confirm-iface-2.patch | 3.88 KB | kim.pepper |
Comments
Comment #1
kim.pepper"Having a crack" as they say here.
Comment #2
kim.pepperFirst shot at the conversion.
Comment #4
kim.pepper#2: 1946444-convert-path-confirm-iface-2.patch queued for re-testing.
Comment #6
kim.pepperWasn't loading the path alias correctly, which I'm now doing by injecting a Path crud object on the form and calling path->load().
Thanks to @timplunkett for the IRC help.
Comment #8
tim.plunkettYou can't typehint with 'int', especially since it could be an int or string.
Comment #9
kim.pepperRemoved type hinting per #8 and fixed some docs.
Comment #10
tim.plunkettLooks good to me!
Comment #11
catchhmm shouldn't the cancel path be a route rather than a path?
Comment #12
catchOpened #1963394: ConfirmFormBase::getCancelPath() should allow for a route since this is a bit of a can of worms. Committed/pushed to 8.x.