node_theme() doesn't declare the file that theme_node_admin_overview() lives in.
This doesn't cause a problem for node module, since it only invokes that theme function from inside that file.
But it's a WTF for another module wanting to use that theme function.
It's also a potential future bug should we ever move some of that code around.
Comment | File | Size | Author |
---|---|---|---|
#6 | 1945066-6-node-theme.patch | 434 bytes | dcam |
#1 | add-file-declaration-for-node_theme-1945066-1.patch | 454 bytes | chertzog |
Comments
Comment #1
chertzogHere you go.
Comment #2
joachim CreditAttribution: joachim commentedLooks perfect, thanks!
Comment #3
xjm#1: add-file-declaration-for-node_theme-1945066-1.patch queued for re-testing.
Comment #4
xjmComment #5
webchickOh, this has bit me before too! Thanks for the fix!
Committed and pushed to 8.x. Moving down to 7.x.
Comment #6
dcam CreditAttribution: dcam commentedBackported #1 to D7.
Comment #7
dcam CreditAttribution: dcam commentedStatus....
Comment #8
joachim CreditAttribution: joachim commentedComment #9
David_Rothstein CreditAttribution: David_Rothstein commentedCommitted to 7.x - thanks! http://drupalcode.org/project/drupal.git/commit/7ba00c1