_menu_translate() doesn't care about new routes

Here is test and a fix.

It's amazing that you can use a Drupal Unit test to test access.

One thing I'm not sure about is that _menu_translate() doesn't care about symfony routers at all, even it's called in a lot of places:

• contextual links
• local tasks
• menu_get_item (that's probably not something which will exists in the future)

There is a route defined for it:

views_ui.edit:
  pattern: '/admin/structure/views/view/{view}'
  options:
    tempstore:
      view: 'views'
  defaults:
    _controller: '\Drupal\views_ui\Routing\ViewsUIController::edit'
  requirements:
    _permission: 'administer views'

The problem is somehow a bit deeper. The backtrace is something like:
ContextualController.php:44->render()
contextual.module:contextual_pre_render_links()
menu_contextual_links()
menu_get_item()
_menu_translate()

Compared to the menu_link_.... approach here we don't have the route_name stored in {menu_route}
so there is no obvious way in _menu_translate() to get the route name. I guess we should add this key temporary so it's possible to fix it. Does someone has an oppinion?

#914382: Contextual links incompatible with render cache

This should work already, but I got stuck with writing a test for _menu_translate().

Wow this old menu system could have really tried to not do everything in one function.

#9: drupal-1938960-9.patch queued for re-testing.

That's great!

+++ b/core/lib/Drupal/Core/Access/DefaultAccessCheck.phpundefined
@@ -26,6 +26,6 @@ public function applies(Route $route) {
   public function access(Route $route, Request $request) {
-    return (bool) $route->getRequirement('_access');
+    return $route->getRequirement('_access') === 'TRUE';
   }

OOOH This one could certainly get a unit test

Here is one.

We certainly don't need tests anymore.