Convert aggregator theme tables to table #type

Added a @todo about the classes

        // @todo add this this the second column: 'class' => array('categorize-item'),
        // @see http://drupal.org/node/1876712#comment-7156742

I have a feeling that if we used #rows instead of child elements(like normal #theme=>table expects, we could do this cell attributes but it will skip "drupal_pre_render_table", it may also not work with the form api but that's just a guess...

+++ b/core/modules/aggregator/aggregator.pages.incundefined
@@ -242,11 +238,33 @@ function aggregator_categorize_items($items, $feed_source = '') {
+        $categories = $form['categories'][$key];
+        unset($form['categories'][$key]);
...
+        $form['items'][$key]['categories'] = $categories;

I dont understand why we need $categories variable here and unset()?

+++ b/core/modules/aggregator/aggregator.pages.incundefined
@@ -242,11 +238,33 @@ function aggregator_categorize_items($items, $feed_source = '') {
+        // @todo add this this the second column: 'class' => array('categorize-item'),
+        // @see http://drupal.org/node/1876712#comment-7156742

I think this class is not used anywhere so you can easily just kill it here.

Cell class killed. Refactored the loops a bit and removed the unset()/$categories shuffling.

Also, not sure if this is a bug or intended functionality but when you unselect two categories, it rechecks the "automatically checked category" (which is fair enough but it would make sense on the create state to do this and if manual changes are made they are respected over the automatic). And weirder yet, if you uncheck the "auto" category and check the "non-auto" and hit save, it decides that you are wrong and checks only the "auto" category. If that doesn't sound right to other people I will open another issue for that.

On second look, I may have broken something along the way... this may need some tests for the above functionality.

Well I did further testing and now it seems to be working as expected, so weird, may still need tests though. Thoughts?

There are already tests for this one..it is just that an item inherits category from its feed
This seems a lot better..

Just one thing

+++ b/core/modules/aggregator/aggregator.pages.incundefined
@@ -211,42 +211,48 @@ function _aggregator_page_list($items, $op, $feed_source = '') {
+  if ($items) {
+    $form_items = entity_view_multiple($items, 'default');
+
+    if (!empty($form_items)) {

lets make this one line: if ($items && $form_items = entity_view_multiple($items, 'default'))

Made the changes as per #6 removing tag as per above comment.

Minor indentation fix. Added Novice tag as per meta.

Seems good to me and testbot agrees

Looks great. Committed/pushed to 8.x.