Minor : core/modules/node/lib/Drupal/node/Plugin/views/area/ListingEmpty.php :

+/**
+ * @file
+ * Contains \Drupal\node\Plugin\views\area\LinkAdd.
+ */

Stale class name in the @file docblock ?

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

Issue tags: +Novice, +VDC

Adding some tags.

sidharthap’s picture

Status: Active » Needs review
FileSize
551 bytes

Here i am attaching a patch to correct it.
This is my first attempt to commit something. Please correct me if did any mistake.

jhodgdon’s picture

Assigned: Unassigned » jhodgdon
Status: Needs review » Reviewed & tested by the community

Thanks -- it looks like you figured out patching correctly! I'll get this committed when I can.

sidharthap’s picture

Thank you..........

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Looking for easy pickings, so... :)

Committed to 8.x. Thanks! Will push once testbot is caught up.

jhodgdon’s picture

Assigned: jhodgdon » Unassigned
ParisLiakos’s picture

Status: Fixed » Needs work
diff --git a/core/modules/node/lib/Drupal/node/Plugin/views/area/ListingEmpty.php b/core/modules/node/lib/Drupal/node/Plugin/views/area/ListingEmpty.php
old mode 100644
new mode 100755

:(

YesCT’s picture

I dont know what that means...
but can we just make a patch to reverse that?

diff --git a/core/modules/node/lib/Drupal/node/Plugin/views/area/ListingEmpty.php b/core/modules/node/lib/Drupal/node/Plugin/views/area/ListingEmpty.php
old mode 100755
new mode 100644

--

If someone knows a link to more info about that... I'll try google.
http://stackoverflow.com/questions/1257592/removing-files-saying-old-mod...
oh, maybe something about permissions! 755, 644

so maybe the way to make a new patch here, is to change the permissions back on that file, and then do a git diff in the usual way.

jibran’s picture

Status: Needs work » Needs review
FileSize
3.45 KB

These are not the only files with wrong permissions there are alot of files with wrong permissions we should start a followup.
@YesCT Securing file permissions and ownership

YesCT’s picture

Status: Needs review » Needs work

whoa. I think here we should just fix this one caused by this commit.

Or, just take care of it (them all) in a follow-up.

Actually, I would suggest we just do this one here. AND do a follow-up for the rest of them.

jibran’s picture

Status: Needs work » Needs review
FileSize
185 bytes

Patch as per #10

YesCT’s picture

Status: Needs review » Reviewed & tested by the community

rtbc if green.

ParisLiakos’s picture

yes we should fix just just the one introduced here..thanks for the patch and sorry for not being descriptive

calmher’s picture

FileSize
185 bytes

As discussed with YesCT, just reposting the patch to correct file permission on core/modules/node/lib/Drupal/node/Plugin/views/area/ListingEmpty.php

jhodgdon’s picture

Status: Reviewed & tested by the community » Fixed

Committed this patch.

Can someone file an issue to fix the other permissions problems?

jibran’s picture

YesCT’s picture

Thanks @calmher

Sometimes we want to retest a patch that is already posted, and we use the re-test link on the comment that has the patch. I think that helps eliminate confusion of posting same patches. :)

Automatically closed -- issue fixed for 2 weeks with no activity.