Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Minor : core/modules/node/lib/Drupal/node/Plugin/views/area/ListingEmpty.php :
+/**
+ * @file
+ * Contains \Drupal\node\Plugin\views\area\LinkAdd.
+ */Stale class name in the @file docblock ?
Comment | File | Size | Author |
---|---|---|---|
#14 | follow-up-1938132-14.patch | 185 bytes | calmher |
#11 | follow-up-1938132-11.patch | 185 bytes | jibran |
#9 | follow-up-1938132-9.patch | 3.45 KB | jibran |
#2 | node-view-area-1938132-2.patch | 551 bytes | sidharthap |
Comments
Comment #1
dawehnerAdding some tags.
Comment #2
sidharthapHere i am attaching a patch to correct it.
This is my first attempt to commit something. Please correct me if did any mistake.
Comment #3
jhodgdonThanks -- it looks like you figured out patching correctly! I'll get this committed when I can.
Comment #4
sidharthapThank you..........
Comment #5
webchickLooking for easy pickings, so... :)
Committed to 8.x. Thanks! Will push once testbot is caught up.
Comment #6
jhodgdonComment #7
ParisLiakos CreditAttribution: ParisLiakos commented:(
Comment #8
YesCT CreditAttribution: YesCT commentedI dont know what that means...
but can we just make a patch to reverse that?
--
If someone knows a link to more info about that... I'll try google.
http://stackoverflow.com/questions/1257592/removing-files-saying-old-mod...
oh, maybe something about permissions! 755, 644
so maybe the way to make a new patch here, is to change the permissions back on that file, and then do a git diff in the usual way.
Comment #9
jibranThese are not the only files with wrong permissions there are alot of files with wrong permissions we should start a followup.
@YesCT Securing file permissions and ownership
Comment #10
YesCT CreditAttribution: YesCT commentedwhoa. I think here we should just fix this one caused by this commit.
Or, just take care of it (them all) in a follow-up.
Actually, I would suggest we just do this one here. AND do a follow-up for the rest of them.
Comment #11
jibranPatch as per #10
Comment #12
YesCT CreditAttribution: YesCT commentedrtbc if green.
Comment #13
ParisLiakos CreditAttribution: ParisLiakos commentedyes we should fix just just the one introduced here..thanks for the patch and sorry for not being descriptive
Comment #14
calmher CreditAttribution: calmher commentedAs discussed with YesCT, just reposting the patch to correct file permission on core/modules/node/lib/Drupal/node/Plugin/views/area/ListingEmpty.php
Comment #15
jhodgdonCommitted this patch.
Can someone file an issue to fix the other permissions problems?
Comment #16
jibranCreated #1948148: Update file permissions
Comment #17
YesCT CreditAttribution: YesCT commentedThanks @calmher
Sometimes we want to retest a patch that is already posted, and we use the re-test link on the comment that has the patch. I think that helps eliminate confusion of posting same patches. :)