The preg_match() regexes in openid.inc will not span any newlines within the tags e.g:

<meta http-equiv="X-XRDS-Location"
content="http://www.myopenid.com/xrds?username=jpstacey.myopenid.com" />

will fail, because of the newline before the content attribute. Please find attached a simple patch to fix these with the "s" switch on the regexes.

(As an aside: my OpenID has been working fine previously without that X-XRDS-Location header. Is that an OpenID2 thing? Because I don't think e.g. AOL supports it: see this howto. Is there any fallback for using just the openid.delegate and openid.server links, as my OpenID didn't work with just those in the HTML?)

CommentFileSizeAuthor
drupal_openid_patch.txt1.47 KBjp.stacey
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Dries’s picture

Status: Needs review » Fixed

This looks correct. Committed to CVS HEAD. Thanks.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.