The preg_match() regexes in openid.inc will not span any newlines within the tags e.g:
<meta http-equiv="X-XRDS-Location"
content="http://www.myopenid.com/xrds?username=jpstacey.myopenid.com" />
will fail, because of the newline before the content attribute. Please find attached a simple patch to fix these with the "s" switch on the regexes.
(As an aside: my OpenID has been working fine previously without that X-XRDS-Location header. Is that an OpenID2 thing? Because I don't think e.g. AOL supports it: see this howto. Is there any fallback for using just the openid.delegate and openid.server links, as my OpenID didn't work with just those in the HTML?)
Comment | File | Size | Author |
---|---|---|---|
drupal_openid_patch.txt | 1.47 KB | jp.stacey |
Comments
Comment #1
Dries CreditAttribution: Dries commentedThis looks correct. Committed to CVS HEAD. Thanks.
Comment #2
(not verified) CreditAttribution: commentedAutomatically closed -- issue fixed for two weeks with no activity.