Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Comment | File | Size | Author |
---|---|---|---|
#9 | 1937998-forminterface-update-drupal-9.patch | 10.67 KB | ACF |
#7 | 1937998-forminterface-update-drupal-7.patch | 10.67 KB | ACF |
#5 | 1937998-forminterface-update-drupal-5.patch | 16.91 KB | ACF |
#2 | 1937998-forminterface-update-drupal-2.patch | 10.64 KB | amateescu |
#2 | interdiff.txt | 1.88 KB | amateescu |
Comments
Comment #1
ACF CreditAttribution: ACF commentedComment #2
amateescu CreditAttribution: amateescu commentedUpdated the patch as an example of how things have to look like after #1934832: Provide a dedicated approach for using forms in routes got committed. What the interdiff is missing is that we no longer need to register a service for the new form class.
Comment #3
amateescu CreditAttribution: amateescu commentedAdd sprintweekend tag.
Comment #4
Crell CreditAttribution: Crell commentedThis should now be a route key, specifying the route name.
Other than that, this looks fine.
Comment #5
ACF CreditAttribution: ACF commentedA re-roll with that change.
Comment #6
Crell CreditAttribution: Crell commentedUh, whut? Why are you defining a class that duplicates SystemConfigFormBase and then not using it...?
Comment #7
ACF CreditAttribution: ACF commentedOops left in some old code.
Comment #8
amateescu CreditAttribution: amateescu commentedSeems a bit weird that in all the other conversions we had the calls to parent methods at the end of the methods and here is at the top, can we move this one as well?
Comment #9
ACF CreditAttribution: ACF commentedMade change.
Comment #10
amateescu CreditAttribution: amateescu commentedLooking good now :)
Comment #11
webchickCommitted and pushed to 8.x. Thanks!