Update CKEditor library to 4.1 RC and remove CKEditor default style configuration

If this is passing testbot, I don't see a particular reason not to commit this since it's simply updating a library. Marking RTBC and I'll commit it later on tonight if no objections.

Yeah, I think we should avoid innocuous titles like "update a library" and at the same time sliding in adjustments to our integration code. These particular changes aren't necessary to update the library, but they're related: The new build specifically excludes CKEditor's default style.js file:

deleted file mode 100644
index 9cd1c13..0000000
--- a/core/misc/ckeditor/styles.js
+++ /dev/null

By removing this file, we're no longer letting CKEditor provide any default styles. This means that we need to make the default Drupal configuration of CKEditor match it, so this patch also adjusts the "stylecombo" integration plugin and the default configuration sent by Drupal.

Really the update of the library to a new version and the removal of the style.js file probably should have been two issues as each is a different problem, but Wim took the opportunity of the library update to remove the default style configuration at the same time. I updated the title to reflect this.

--- a/core/modules/ckeditor/lib/Drupal/ckeditor/Plugin/editor/editor/CKEditor.php
+++ b/core/modules/ckeditor/lib/Drupal/ckeditor/Plugin/editor/editor/CKEditor.php
@@ -125,6 +125,12 @@ public function getJSSettings(Editor $editor) {
       'contentsCss' => $this->buildContentsCssJSSetting($editor),
       'extraPlugins' => implode(',', array_keys($external_plugins)),
       'language' => $language_interface->langcode,
+      // Configure CKEditor to not load styles.js. The StylesCombo plugin will
+      // set stylesSet according to the user's settings, if the "Styles" button
+      // is enabled. We cannot get rid of this until CKEditor will stop loading
+      // styles.js by default.
+      // See http://dev.ckeditor.com/ticket/9992#comment:9.
+      'stylesSet' => FALSE,
     );

I suggested this comment be made, but this is probably a bit overly verbose. It's not worth holding up the issue though. This gets +1 RTBC from me.

Oh oops, sorry for not digging in more. Thanks for the heads-up, and the +1. :)

Committed and pushed to 8.x. Thanks! It's great to get this updated for the forthcoming Drupal Global Sprint Weekend so we can do some testing.

I don't think we need a change notice particularly for this (moreso when we move to a stable version), so marking directly to fixed, and removing the "sprint" tag.

where are we supposed to place this patch exactly?