there's no way that people should be updating from a pre-4.7 install directly to 6.x. attached rips out all pre-4.7 updates, which technically aren't even supported anymore. anybody who does happen to have an older install that needs to be upgraded can obtain older versions from CVS if necessary.

CommentFileSizeAuthor
#6 patch.txt3.19 KBwebernet
#1 kill_old_updates_2.patch72.42 KBwebernet
kill_old_updates.patch71.66 KBhunmonk
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

webernet’s picture

webernet CreditAttribution: webernet commented
Status: Active » Needs review
FileSize
kill_old_updates_2.patch72.42 KB

Added a changelog entry.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented

Looks sensible to me and I agree with the CHANGELOG.txt entry (although this is specified in every upgrade doc ever). I think it may be feasibly possible to upgrade from 4.6 to 6.x though. Do we want to stop people from doing that even if it works?

hunmonk’s picture

hunmonk CreditAttribution: hunmonk commented

i think we do. 4.6 isn't even supported anymore, and should be considered a security risk -- in which case we shouldn't have any 4.6 related code hanging around... ;)

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs review » Reviewed & tested by the community

Applies cleanly with a bit of offset, patch is straightforward. Putting it in the comitters queue for a decision.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Reviewed & tested by the community » Fixed

Such a said moment for me :| I have known this day would come, but I do have a 4.6 site which I can upgrade to 6 automatically with a strikingly small number of errors (actually, only the node type related changes need modifications and a menu rebuilding line commented out :). Anyway, understandably I am of the power user kind, so I can copy back this update function set into my system.install and run it myself, while Drupal's official policy is not to support direct upgrades from unsupported versions, so this change is quite sensible.

Hah, committed.

webernet’s picture

webernet CreditAttribution: webernet commented
Status: Fixed » Needs review
FileSize
patch.txt3.19 KB

I realized that we ripped out a bit two much...

This patch restores the 4.7.x updates from after the 4.7.0 release including those from the 4.7 branch that were never applied to head.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

Are any Drupal 5.x update functions missing?

webernet’s picture

webernet CreditAttribution: webernet commented

The 5.x extra updates look OK, 1022 exists in head.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Needs review » Fixed

OK, committed. Thanks.

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.