Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem
system.performance
contains performance related configuration settings already.- When
system.fast_404
is needed,system.performance
is needed, too.
Proposed solution
- Merge
system.fast_404
intosystem.performance
.
Comment | File | Size | Author |
---|---|---|---|
#12 | 1934716-fast-404-default-settings-typo.patch | 1.2 KB | hackwater |
#8 | 4-8-interdiff.txt | 1.58 KB | alexpott |
#8 | 1934716.fast_404.8.patch | 7.79 KB | alexpott |
#4 | 1-4-interdiff.txt | 3.65 KB | alexpott |
#4 | 1934716.fast_404.4.patch | 7.69 KB | alexpott |
Comments
Comment #1
alexpottPatch merges the configs and adds an upgrade path test.
Actually using update_variables_to_config for these variable is interesting as in D7 they are declared in settings.php and D8 they can be in config... but must read original conversion issue to see if this was discussed :) #1778478: Convert fast_404 to CMI - doesn't appear so... but this issue should be for a follow up. Relatedly, I'm not sure why we still have the comments in defaults.settings.php (imho) this settings should just be added to the system performance ui.
Comment #2
alexpottComment #4
alexpottDoh! $config is no longer a config object... this ain't gonna work :)
Also forgot to update default.settings.php
Comment #5
alexpottWhy do I always forget this :(
Comment #6
sunYay, awesome, thanks! :)
Comment #7
webchickSorry, this is not applying for me.
Comment #8
alexpottNeeded reroll due to #1821420: Convert mail variables to cmi making unrelated whitespace changes to drupal-7.system.database.php
When green this should be back to rtbc
Comment #9
sunIn the hope it comes back green.
Comment #10
webchickCommitted and pushed to 8.x. Thanks!
Comment #12
hackwater CreditAttribution: hackwater commentedPatch in #8 had a typo in the default.settings.php file that affects all generated settings.php files; if the fast_404 option is enabled, the missing end quote in 'system.performance' leads to a PHP syntax error.
Comment #14
hackwater CreditAttribution: hackwater commented#12: 1934716-fast-404-default-settings-typo.patch queued for re-testing.
Comment #15
LinL CreditAttribution: LinL commentedLooks good.
Comment #16
LinL CreditAttribution: LinL commentedComment #17
alexpottNice catch... and oops :)
Committed c750885 and pushed to 8.x. Thanks!