Saving anything on handlers isn't stored properly

I tracked it down to the following line:

call_user_func($submit_handler, $form, $form_state);

with submit_handler containing the proper information, but ConfigItem::submitForm() is simply not called :(

This should be probably major.

Here is a fix, but I'm not really sure why this works and the previous code does not.

Fact is, we have test coverage for simply stuff like that, but maybe the tests work slightly different?

Warning this patch size is 666 bytes, so this might be caught by php 5.4 :P

Yeah your last patch works as well, see the comment about it on http://php.net/manual/en/function.call-user-func-array.php

Let's do that now, and maybe later switch to just use the method call.

Well I agree it would be great if we could have tests for that, but how can we test code, which just works on a certain php version, and not on a newer version?

The current code in core works fine in php 5.3, but not in php 5.4.

So this time with a new comment?

@andymartha
I can't reproduce that, but yeah maybe open another issue and describe how to reproduce this problem.