Rename toolbar "menu" tab to "manage"

Agreed.

here's a patch with the menu change:

Applied to 8.x-dev branch cleanly and works as advertised.

+1

[Update] After thinking again about it... I prefer stays as it is. It's a menu, and has a "Menu" icon. It's consistent and fast to understand. It's better than "Admin", that it's ambiguous.
Also, think about users with very limited permissions. their Menu could be very small and not representing anything related to Administration.

context for translators would be nice, so they know "admin" is administration can be done with t() https://api.drupal.org/api/drupal/core%21includes%21bootstrap.inc/functi... is the d8 api for t() which shows how.

Although, maybe that doesn't need to hold this up.

"Home" doesn't have context and I think it would need it for similar reasons.

Here is the code for Home:

  // The 'Home' tab is a simple link, with no corresponding tray.
  $items['home'] = array(
    '#type' => 'toolbar_item',
    'tab' => array(
      '#type' => 'link',
      '#title' => t('Home'),
      '#href' => '<front>',
      '#options' => array(
        'attributes' => array(
          'title' => t('Home page'),
          'class' => array('toolbar-icon', 'toolbar-icon-home'),
        ),
      ),
    ),
    '#weight' => -20,
  );

I was going to say that we should get the point of view of a Toolbar maintainer but we don't have one. For me the issue here is that this is in a toolbar not a menu... and it opens the admin menu. The other options on the toolbar do not necessary open a menu. Also as the screenshot shows a lot of people create a user called admin so this looks odd to.

To put my concerns a little bit more succinctly is:

Home | Admin | Shortcuts | admin

better than

Home | Menu | Shortcuts | admin

Also the I'm not sue that the premise of having a menu item called Menu is entirely correct - it is a toolbar tray item.

Yhea, I am not sure how to resolve that. Perhaps we can rename the last item to "User" though that really only makes it more usable in the case you call your admin user "admin".

I dont really know how to resolve the issue, other than redesigning the toolbar.

So I don't know how to resolve this, guess this is a won't fix. Leaving it to needs review, maybe someone knows how to resolve this.

So actually I'm going to set this to needs review based on #11 - for me if we want to avoid something that looks like a menu item being called "Menu" then we should replace it was "Admin menu" but the more I think about it the more against just changing this to "Admin" I am due to the clash with a very common username.

i don't know what is best here either. Administration, at the very least, is consistent...

Yhea, the issue will still somewhat stand though. I am not sure if we really need the full name to be honest. Its just a way that we do things, I don't know if its actually more or less usable.

I asked @tkoleary to chime in here, since he designed the toolbar.

I tried to understand the issue and summarize it.

Awesome, thanks for doing that! :)

If you are looking for a distinct term that indicates what is within the 'menu', I would recommend 'manage'. You could be a site administrator or a content manager who needs to accomplish tasks in the current 'menu' tab. Thus, this would cover more user scenarios. Also, it is distinct from the 'admin' user name which could have different connotations since it is used so often for other mediums. Some users may not consider themselves admins, but they may all need to manage content.

Home | Manage | Shortcuts | admin

Just a thought.

home is not here anymore but manage sounds good.

This is being resolved by #2151137: Rename the 'Menu' Toolbar tab to 'Administration'; Leave the 'Menu' namespace open to themes and modules for site navigation.

Actually, since this one is older, and has more discussion, flipping the issue statuses.

It sounds like we settled here on "manage" vs. "admin" because of various issues w/ that, so re-titling and setting to needs work.

Also, some tags.

a quick fix changing "Menu" to "Manage".

I like the way "manage" reads when you are clicking through the menu. It flows nicely, "manage.. people", "manage.. structure".

#25 applies and works as advertised.

I like "manage", sounds like you have more direct control over the items. "admin" from "administer" sounds more like "organizing" or "being in charge". But English is not my native language, just bike-shedding.

Two more screenshots using #25 patch, that was applied without problems in simplytest.me
https://www.monosnap.com/image/FDuChi1SaYCMmUygfUJxooGM6
https://www.monosnap.com/image/MplQhWto1f8ZB7wf7GO3WPC4Y

Ok, let's do this! The sooner it gets in, the sooner everyone can update their respective docs.

Committed and pushed to 8.x. Thanks!

I dont see a commit for this one.

Setting this back to RTBC.

Committed 754536a and pushed to 8.x. Thanks!