Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
The CSS file in the aggregator module does not apply to any actual HTML provided by the module's markup. This happened after the refactoring in #293318: Convert Aggregator feeds into entities
The remaining CSS is pretty pathetic too.
.aggregator .feed-icon {
float: right; /* LTR */
display: block;
}
In the rest of Drupal the .feed-icon
doesn't have any special styling. Why does aggregator module need to do something special anyway?
Proposed resolution
Let's just delete the entire file (and its RTL companion.)
Remaining tasks
After this issue's completion, we still have all the other steps outlined at #1921610: [Meta] Architect our CSS.
User interface changes
none
API changes
none
Comment | File | Size | Author |
---|---|---|---|
#3 | 1924528-1-remove-aggregator-css-before.png | 50.12 KB | andymartha |
#3 | 1924528-1-remove-aggregator-css-after.png | 49.12 KB | andymartha |
#1 | 1924528-1-remove-aggregator-css.patch | 1.27 KB | JohnAlbin |
Comments
Comment #1
JohnAlbinHere's the patch.
Comment #2
Shyamala CreditAttribution: Shyamala commentedAdding tags
Comment #3
andymartha CreditAttribution: andymartha commentedI can confirm that patch 1924528-1-remove-aggregator-css.patch in #1 by JohnAlbin removes the files in the initial problem on a fresh installation of Drupal 8.x-dev. See screenshots and thanks!
Comment #4
Dries CreditAttribution: Dries commentedCommitted to 8.x. Thanks.