Problem/Motivation

The CSS file in the aggregator module does not apply to any actual HTML provided by the module's markup. This happened after the refactoring in #293318: Convert Aggregator feeds into entities

The remaining CSS is pretty pathetic too.

.aggregator .feed-icon {
  float: right; /* LTR */
  display: block;
}

In the rest of Drupal the .feed-icon doesn't have any special styling. Why does aggregator module need to do something special anyway?

Proposed resolution

Let's just delete the entire file (and its RTL companion.)

Remaining tasks

After this issue's completion, we still have all the other steps outlined at #1921610: [Meta] Architect our CSS.

User interface changes

none

API changes

none

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

JohnAlbin’s picture

Status: Active » Needs review
FileSize
1.27 KB

Here's the patch.

Shyamala’s picture

Issue tags: +mobile, +d8mux, +d8mux-css-cleanup

Adding tags

andymartha’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
49.12 KB
50.12 KB

I can confirm that patch 1924528-1-remove-aggregator-css.patch in #1 by JohnAlbin removes the files in the initial problem on a fresh installation of Drupal 8.x-dev. See screenshots and thanks!

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks.

Automatically closed -- issue fixed for 2 weeks with no activity.