Create configuration schemas for filter module [#1919174]

This is a sub-issue of #1910624: [META] Introduce and complete configuration schemas in all of core.

Problem/motivation

#1866610: Introduce Kwalify-inspired schema format for configuration introduced the idea of config schema. The changelog leads to (hopefully extensive) documentation on the format at http://drupal.org/node/1905070. While there are little cleanups planned for the format overall, the current format is a result of months of back and forths, so it should be perfectly fine to apply it more widely to core.

Proposed solution

Create a configuration schema for file module.

Schema in place

Schema not yet in place
filter.settings.yml
filter.format.plain_text.yml

Comment	File	Size	Author
#16	1919174-diff-13-15.patch	563 bytes	mr.york
#16
#15	1919174-filter-schema-15_0.patch	1.77 KB	mr.york
#15
#13	1919174-filter-schema-13.patch	1.67 KB	vijaycs85
#13
#13	1919174-diff-9-13.txt	1.53 KB	vijaycs85
#9	1919174-filter-schema-9.patch	1.59 KB	vijaycs85
#9
#9	1919174-diff-7-9.txt	1.04 KB	vijaycs85
#8	2013-02-21_215035.png	9.46 KB	vijaycs85
#7	1919174-filter-schema-7.patch	1.27 KB	vijaycs85
#7
#7	1919174-diff-5-7.txt	726 bytes	vijaycs85
#5	1919174-filter-schema-5.patch	1.25 KB	vijaycs85
#5
#5	1919174-diff-3-5.txt	704 bytes	vijaycs85
#3	1919174-filter-schema-3.patch	1.32 KB	vijaycs85
#3
#3	1919174-diff-1-3.txt	420 bytes	vijaycs85
#1	1919174-filter-schema.patch	1.32 KB	vijaycs85
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

vijaycs85

London, UK

CreditAttribution: vijaycs85 commented 16 February 2013 at 22:21

Status:

Active

» Needs review

File	Size
1919174-filter-schema.patch	1.32 KB

Adding schema file...

Comment #2

16 February 2013 at 23:23

Status:

Needs review

» Needs work

The last submitted patch, 1919174-filter-schema.patch, failed testing.

Comment #3

vijaycs85

London, UK

CreditAttribution: vijaycs85 commented 17 February 2013 at 10:54

Status:

Needs work

» Needs review

File	Size
1919174-diff-1-3.txt	420 bytes
1919174-filter-schema-3.patch	1.32 KB

Fixing typo...

Comment #4

17 February 2013 at 12:31

Status:

Needs review

» Needs work

The last submitted patch, 1919174-filter-schema-3.patch, failed testing.

Comment #5

vijaycs85

London, UK

CreditAttribution: vijaycs85 commented 17 February 2013 at 16:10

Status:

Needs work

» Needs review

File	Size
1919174-diff-3-5.txt	704 bytes
1919174-filter-schema-5.patch	1.25 KB

Removing type def: filter

Comment #6

17 February 2013 at 16:12

Status:

Needs review

» Needs work

The last submitted patch, 1919174-filter-schema-5.patch, failed testing.

Comment #7

vijaycs85

London, UK

CreditAttribution: vijaycs85 commented 17 February 2013 at 20:05

Status:

Needs work

» Needs review

File	Size
1919174-diff-5-7.txt	726 bytes
1919174-filter-schema-7.patch	1.27 KB

Re-rolling with fixes.

Comment #8

vijaycs85

London, UK

CreditAttribution: vijaycs85 commented 21 February 2013 at 16:34

Status:

Needs review

» Needs work

File	Size
2013-02-21_215035.png	9.46 KB

In filter.format.full_html.yml

format: full_html
...
...
...
filters:
  filter_url:
    module: filter
    status: '1'
  filter_autop:
    module: filter
    status: '1'
  filter_htmlcorrector:
    module: filter
    status: '1'

In filter.format.php_code.yml

format: php_code
...
...
...
filters:
  php_code:
    module: php
    status: '1'
langcode: und

To update them in Schema file(filter.schama.yml):

filter.format.*:
  type: mapping
  label: 'Filter format'
...
...
...
    filters:
      type: sequence
      label: 'Filters'
      sequence:
        - type: format.filter.[%key]

Where as %key has been defined as

format.filter.filter_html_escape:
  type: filter
  label: 'Filter HTML'

format.filter.filter_url:
  type: filter
  label: 'Filter URL'

format.filter.filter_autop:
  type: filter
  label: 'Filter autotop'

format.filter.php_code:
  type: filter
  label: 'PHP filter'

and filter defined in system.data_types.schema.yml

# Filter with module and status.
filter:
  type: mapping
  label: 'Filter'
  mapping:
    module:
      type: string
      label: 'Module'
    status:
      type: boolean
      label: 'Status'

when visit admin/reports/config-inspector/filter.format.php_code/form, I' getting all filters defined, instead of just PHP's (i.e. php_code)

Am I doing anything wrong here?

Comment #9

vijaycs85

London, UK

CreditAttribution: vijaycs85 commented 22 February 2013 at 13:21

Status:

Needs work

» Needs review

File	Size
1919174-diff-7-9.txt	1.04 KB
1919174-filter-schema-9.patch	1.59 KB

Comment #10

22 February 2013 at 14:29

Status:	Needs review	» Needs work
Issue tags:	-Configuration system, -D8MI, -language-config, -Configuration schema

The last submitted patch, 1919174-filter-schema-9.patch, failed testing.

Comment #11

vijaycs85

London, UK

CreditAttribution: vijaycs85 commented 22 February 2013 at 14:31

Status:

Needs work

» Needs review

#9: 1919174-filter-schema-9.patch queued for re-testing.

Comment #12

22 February 2013 at 15:53

Status:	Needs review	» Needs work
Issue tags:		+Configuration system, +D8MI, +language-config, +Configuration schema

The last submitted patch, 1919174-filter-schema-9.patch, failed testing.

Comment #13

vijaycs85

London, UK

CreditAttribution: vijaycs85 commented 28 February 2013 at 17:34

File	Size
1919174-diff-9-13.txt	1.53 KB
1919174-filter-schema-13.patch	1.67 KB

Re-rolling...

Comment #14

Gábor Hojtsy

he/him

Hungarian

Hungary

CreditAttribution: Gábor Hojtsy commented 28 February 2013 at 17:37

Status:

Needs work

» Needs review

#9: 1919174-filter-schema-9.patch queued for re-testing.

Comment #15

mr.york CreditAttribution: mr.york commented 9 March 2013 at 10:23

File	Size
1919174-filter-schema-15_0.patch	1.77 KB

Added always_show_fallback_choice config option with the last patch.

Comment #16

mr.york CreditAttribution: mr.york commented 9 March 2013 at 10:44

File	Size
1919174-diff-13-15.patch	563 bytes

Interdiff.

Comment #17

mr.york CreditAttribution: mr.york commented 9 March 2013 at 10:45

Issue tags:

+SprintWeekend2013

Add #sprintweekend tag :).

Comment #18

9 March 2013 at 18:28

Status:

Needs review

» Needs work

The last submitted patch, 1919174-diff-13-15.patch, failed testing.

Comment #19

Anonymous (not verified) CreditAttribution: Anonymous commented 9 March 2013 at 20:30

Status:

Needs work

» Reviewed & tested by the community

Ran the test on file and filter module and they seems clean. Also ran node test, found couple of failures but I don't think its related to this issue.