Create configuration schemas for field module [#1919164]

This is a sub-issue of #1910624: [META] Introduce and complete configuration schemas in all of core.

Problem/motivation

#1866610: Introduce Kwalify-inspired schema format for configuration introduced the idea of config schema. The changelog leads to (hopefully extensive) documentation on the format at http://drupal.org/node/1905070. While there are little cleanups planned for the format overall, the current format is a result of months of back and forths, so it should be perfectly fine to apply it more widely to core.

Proposed solution

Create a configuration schema for field module.

Schema in place

Schema not yet in place
field.settings.yml

Comment	File	Size	Author
#11	1919164-11.jpg	27.26 KB	sidharthap
#10	1919164-field-schema-10.patch	481 bytes	sandipmkhairnar
#10
#6	1919164-field-schema-6.patch	480 bytes	sandipmkhairnar
#6
#6	field-schema-form.png	16.7 KB	sandipmkhairnar
#5	1919164-field-schema-5.patch	452 bytes	Vikas Negi
#5
#5	1919164-diff-2-5.txt	1.09 KB	Vikas Negi
#2	1919164-field-schema-2.patch	787 bytes	Vikas Negi
#2
#1	1919164-field-schema.patch	362 bytes	vijaycs85
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

vijaycs85

London, UK

CreditAttribution: vijaycs85 commented 16 February 2013 at 22:01

Status:

Active

» Needs review

File	Size
1919164-field-schema.patch	362 bytes

Adding schema file...

Comment #2

Vikas Negi CreditAttribution: Vikas Negi commented 22 February 2013 at 10:27

File	Size
1919164-field-schema-2.patch	787 bytes

Re-rolling with code style fixes (http://drupal.org/node/1905070#codestyle)

Comment #3

22 February 2013 at 11:35

Status:

Needs review

» Needs work

The last submitted patch, 1919164-field-schema-2.patch, failed testing.

Comment #4

vijaycs85

London, UK

CreditAttribution: vijaycs85 commented 22 February 2013 at 12:11

+++ b/core/modules/field/config/schema/field.schema.ymlundefined
+++ b/core/modules/field/config/schema/field.schema.ymlundefined
@@ -0,0 +1,9 @@

@@ -0,0 +1,9 @@
+# Schema for configuration files of field module.

missing 'the' as per code style :(

+++ b/core/modules/menu/config/menu.settings.ymlundefined
@@ -1,3 +1,3 @@
-main_links: main
+smain_links: main
 secondary_links: account
 override_parent_selector: '0'

typo/mistake?

Comment #5

Vikas Negi CreditAttribution: Vikas Negi commented 22 February 2013 at 12:41

Status:

Needs work

» Needs review

File	Size
1919164-diff-2-5.txt	1.09 KB
1919164-field-schema-5.patch	452 bytes

Fixed changes as per the above comments.

Comment #6

sandipmkhairnar CreditAttribution: sandipmkhairnar commented 4 March 2013 at 13:17

File	Size
field-schema-form.png	16.7 KB
1919164-field-schema-6.patch	480 bytes

Correct the label for purge batch site and update the patch schema form

Comment #7

vijaycs85

London, UK

CreditAttribution: vijaycs85 commented 4 March 2013 at 13:22

+++ b/core/modules/field/config/schema/field.schema.ymlundefined
+++ b/core/modules/field/config/schema/field.schema.ymlundefined
@@ -0,0 +1,9 @@
+# Schema for configuration files of the Field module

One minor issue - Comment missing a full stop(".") at the end.