Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
I came across this issue when trying to build a module that can create entities in a modal dialog via ajax. I'm using enity_create() and entity_form() with great success for nodes, terms and users however I couldn't get a form when it came to vocabs.
I traced it through and it looks to me like entity_metadata_form_taxonomy_vocabulary() was a copy and paste of entity_metadata_form_taxonomy_term() but someone forgot to change the name of the arg and the form id.
Here's a patch.
Thanks
Josh
Comment | File | Size | Author |
---|---|---|---|
#6 | code_review_helper-1918644.module.test | 3.24 KB | Alexander Allen |
#5 | issue-1918644-incorrect-form-id.patch | 1.14 KB | Alexander Allen |
#2 | vocab_form_id.patch | 1.07 KB | Alexander Allen |
vocab_form_id.patch | 1.07 KB | sonictruth | |
Comments
Comment #1
jeff h CreditAttribution: jeff h commentedTested and working fine here.
Any maintainers got a few minutes to roll this patch in?
Comment #2
Alexander Allen CreditAttribution: Alexander Allen commentedHmm, the patch was not tested by Drupal. Re-uploading for testing.
Thanks for reporting and fixing this.
Comment #3
Alexander Allen CreditAttribution: Alexander Allen commentedDo'h, this is for 7.x-1.0, needs to be re-rolled and re-tested for the latest.
Comment #4
Alexander Allen CreditAttribution: Alexander Allen commentedComment #5
Alexander Allen CreditAttribution: Alexander Allen commentedRe-uploaded to reflect line numbers in latest version. Line numbers changed slightly (from @@ -892,11 to @@-915,11 ...). Re-roll applied cleanly for me on the 7.x-1.x dev version.
Comment #6
Alexander Allen CreditAttribution: Alexander Allen commentedTested. Changing
to
returns a proper taxonomy vocabulary form.
In my test, attempting to retrieve a 'taxonomy_form_term' form resulted in a Drupal error page.
Test attached.
Comment #7
fagoops - I guess that was me ;)
Thanks, committed.