The Comment mark is not placed within Type folder. Simple patch.

CommentFileSizeAuthor
#7 comment-mark-1913620-7.patch2.65 KBandypost
#4 comment-mark-1913620-4.patch2.89 KBandypost
comment-mark.patch2.78 KBandypost
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Active » Needs review
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented

comment-mark.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, comment-mark.patch, failed testing.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Needs work » Needs review
FileSize
comment-mark-1913620-4.patch2.89 KB

Re-roll

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Issue tags: +Field API, +Entity Field API, +typed data

taggin

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented

We actually killed the Type namespace directory, as things are now registered as a plugin in Plugin/DataType. As this is not registered as a datatype but defined explicitly in the definitions with the class, this might not be necessary.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
FileSize
comment-mark-1913620-7.patch2.65 KB

I found that there's Drupal\text\TextProcessed so let's simply rename the files

afeijo’s picture

afeijo
Primary language Portuguese, Brazil
Location Porto Alegre
CreditAttribution: afeijo commented
Status: Needs review » Reviewed & tested by the community

I review this patch and it worked in my brand new D8

YesCT’s picture

YesCT CreditAttribution: YesCT commented
Issue tags: +RTBC July 1

This issue was RTBC and passing tests on July 1, the beginning of API freeze.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.