Sub-task of #1862398: [meta] Replace drupal_http_request() with Guzzle.
I've included the timeout but it can always be removed if not needed.
+++ b/core/modules/search/lib/Drupal/search/Tests/SearchRankingTest.phpundefined @@ -16,6 +16,13 @@ class SearchRankingTest extends SearchTestBase { + /** + * The Guzzle HTTP client. + * + * @var \Guzzle\Http\ClientInterface; + */ + protected $client;
I don't think this is necessary, it's just used once, so just do $client = ...
+++ b/core/modules/search/lib/Drupal/search/Tests/SearchRankingTest.phpundefined @@ -80,13 +87,15 @@ function testRankings() { + $this->client = drupal_container()->get('http_default_client');
This should now use \Drupal::httpClient()
Looks like guzzle defaults to that content type header if you pass in an array of post fields. Neat.
..double post, see below..
It makes sense:) and this is where statistics.php is being used..i ll know where to look when i will rename it
heh, this looks good, thanks!
All right, let's get this out of the way and close a major!
Committed and pushed to 8.x. Thanks!
Automatically closed -- issue fixed for 2 weeks with no activity.
Comments
Comment #1
adammaloneI've included the timeout but it can always be removed if not needed.
Comment #2
BerdirI don't think this is necessary, it's just used once, so just do $client = ...
This should now use \Drupal::httpClient()
Comment #3
BerdirLooks like guzzle defaults to that content type header if you pass in an array of post fields. Neat.
Comment #4
ParisLiakos CreditAttribution: ParisLiakos commented..double post, see below..
Comment #5
ParisLiakos CreditAttribution: ParisLiakos commentedIt makes sense:)
and this is where statistics.php is being used..i ll know where to look when i will rename it
heh, this looks good, thanks!
Comment #6
webchickAll right, let's get this out of the way and close a major!
Committed and pushed to 8.x. Thanks!