Move array_filter_zero function to FilterPluginBase

Good idea!

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.phpundefined
@@ -1390,6 +1390,19 @@ function can_group() {
+   * @param $var

probably a string?

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.phpundefined
@@ -1390,6 +1390,19 @@ function can_group() {
+  public function arrayFilterZero($var) {

Would it make sense to have a static function as you don't need any kind of values on the main object. Shouldn't this also be protected?

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.phpundefined
@@ -617,7 +617,7 @@ function build_group_validate($form, &$form_state) {
+                (is_array($group['value']) && count(array_filter($group['value'], array($this, 'arrayFilterZero'))) == 0)) {

@@ -625,7 +625,7 @@ function build_group_validate($form, &$form_state) {
+              (is_array($group['value']) && count(array_filter($group['value'], array($this, 'arrayFilterZero'))) > 0)) {

you can use static::arrayFilterZero as alternative syntax

The reasons why it should be protected are the following: a) It's not something which is really useful in connection with other code, so making it public would make the object even more complicated from the outside and b) if someone needs that functionality it's a one line function to implement for their own, that's unneeded abstraction.

Looks good!

RTBC as long it's green.

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.phpundefined
@@ -1390,6 +1390,19 @@ function can_group() {
+  protected static function arrayFilterZero($var) {
+    return trim($var) != "";

I know it's just moving code around but per coding standards this could be single quotes.

I guess this makes sense as a helper function since it's used in two places, but was also wondering about just a closure?

Ups :)

Committed/pushed to 8.x, thanks!