String freeze: "node" to "post" [#191104]

If we have the rule that content is referred to as "posts" rather than "nodes", then the attached instances are bugs.

This cleans up the remaining 'node' and 'nodes' I found that are not in comments, install file Schema API field descriptions, etc., with the exception that there are still a few in the node.module help page, and also in path.module help -- there are other issue in the documentation component queue about cleaning that page up.

Please note that this patch modifies two instances referring to the node access table (and specifically, about rebuilding those permissions). I really wanted to leave these out, but didn't. In general, post is better than node, but in this instance, IMO, post is less clear. But, I changed them anyway.

Comment	File	Size	Author
#5	node_to_posts_2.patch	8.95 KB	keith.smith
#5
	node_to_posts.patch	8.99 KB	keith.smith

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

keith.smith CreditAttribution: keith.smith commented 10 November 2007 at 20:50

I should mention that the presence of "node" in interface text was a comment in the http://factoryjoe.pbwiki.com/FeedbackForDrupal6 commentary.

Comment #2

Dries CreditAttribution: Dries commented 11 November 2007 at 08:43

I'd say these are bugs, and that the proposed patch is an improvement. Sometimes the word 'post' is a little odd, especially when there are special CCK node types involved. To overcome that, we prefer to use the word 'content' when possible. In this patch, "post vs content" is used properly but it might be worth another look. Thanks Keith!

Feel free to mark this RTBC.

Comment #3

catch

he/him

English

CreditAttribution: catch commented 11 November 2007 at 14:04

Status:

Needs review

» Reviewed & tested by the community

Read through and it all looks fine to me.

Comment #4

Gábor Hojtsy

he/him

Hungarian

Hungary

CreditAttribution: Gábor Hojtsy commented 11 November 2007 at 16:28

Status:

Reviewed & tested by the community

» Needs work

I think "post permissions" sounds awkward, as here it sound like "posting permission" (ie. post as a verb). I think "Content permission" would be better there. Usage of terminology around (node) permissions might be good to look around Drupal core. Otherwise all changes look good, but "post permissions" bug me.

Comment #5

keith.smith CreditAttribution: keith.smith commented 12 November 2007 at 16:54

Status:

Needs work

» Needs review

File	Size
node_to_posts_2.patch	8.95 KB

New patch, attached, adjusts the node access rebuild sections.

Dries mentioned setting this RTBC in #2, but I also modified (in this latest patch) a piece of text on the node access rebuild confirmation screen that was not in the original. I think the new text is fine, but some might think it too terse, so I'm going to leave this CNR for reviews. (My reason for modifying this was to get rid of the "a while" construct.)