If we have the rule that content is referred to as "posts" rather than "nodes", then the attached instances are bugs.
This cleans up the remaining 'node' and 'nodes' I found that are not in comments, install file Schema API field descriptions, etc., with the exception that there are still a few in the node.module help page, and also in path.module help -- there are other issue in the documentation component queue about cleaning that page up.
Please note that this patch modifies two instances referring to the node access table (and specifically, about rebuilding those permissions). I really wanted to leave these out, but didn't. In general, post is better than node, but in this instance, IMO, post is less clear. But, I changed them anyway.
Comment | File | Size | Author |
---|---|---|---|
#5 | node_to_posts_2.patch | 8.95 KB | keith.smith |
node_to_posts.patch | 8.99 KB | keith.smith | |
Comments
Comment #1
keith.smith CreditAttribution: keith.smith commentedI should mention that the presence of "node" in interface text was a comment in the http://factoryjoe.pbwiki.com/FeedbackForDrupal6 commentary.
Comment #2
Dries CreditAttribution: Dries commentedI'd say these are bugs, and that the proposed patch is an improvement. Sometimes the word 'post' is a little odd, especially when there are special CCK node types involved. To overcome that, we prefer to use the word 'content' when possible. In this patch, "post vs content" is used properly but it might be worth another look. Thanks Keith!
Feel free to mark this RTBC.
Comment #3
catchRead through and it all looks fine to me.
Comment #4
Gábor HojtsyI think "post permissions" sounds awkward, as here it sound like "posting permission" (ie. post as a verb). I think "Content permission" would be better there. Usage of terminology around (node) permissions might be good to look around Drupal core. Otherwise all changes look good, but "post permissions" bug me.
Comment #5
keith.smith CreditAttribution: keith.smith commentedNew patch, attached, adjusts the node access rebuild sections.
Dries mentioned setting this RTBC in #2, but I also modified (in this latest patch) a piece of text on the node access rebuild confirmation screen that was not in the original. I think the new text is fine, but some might think it too terse, so I'm going to leave this CNR for reviews. (My reason for modifying this was to get rid of the "a while" construct.)
Comment #6
catchYep, addresses Gabor's concerns, concise but not terse, RTBC.
Comment #7
Gábor HojtsyLooks good, thanks, committed.
Comment #8
(not verified) CreditAttribution: commentedAutomatically closed -- issue fixed for two weeks with no activity.