Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
After #1826602: Allow all configuration entities to be enabled/disabled it has become apparent that the status is not updated correctly when views objects are loaded from the user tempstore.
Here is the fix, but we need tests.
I'm on it. I will write some tests in the morning.
Comment | File | Size | Author |
---|---|---|---|
#9 | vdc-1909878-8.patch | 3.8 KB | tim.plunkett |
#8 | 1909878-8.patch | 3.56 KB | damiankloip |
#4 | 1909878-4.patch | 3.52 KB | damiankloip |
#4 | interdiff.txt | 1.11 KB | damiankloip |
#2 | 1909878-2-tests-only.patch | 2.96 KB | damiankloip |
Comments
Comment #1
damiankloip CreditAttribution: damiankloip commentedComment #2
damiankloip CreditAttribution: damiankloip commentedComment #3
dawehnerAwesome!
We could refactor that in the future to use unit tests, as they are just function calls.
I guess a t() function would help here.
vierwrrr, harharhar!
Comment #4
damiankloip CreditAttribution: damiankloip commentedNice, thanks for the review!
I'm not sure about unit tests in the future, as I think we should keep testing this based on UI events, but not sure on that.
I made those other changes, see interdiff.
Comment #5
dawehnerAwesome!
Comment #6
tim.plunkett#4: 1909878-4.patch queued for re-testing.
Comment #8
damiankloip CreditAttribution: damiankloip commentedRerolled to use the new stuff from the views UI routes patch.
Comment #9
tim.plunkettRerolled for #1904854: Convert Views UI to routes
Comment #10
damiankloip CreditAttribution: damiankloip commentedx post? I think #9 might fail. Didn't you remove views_ui_cache_load? :)
Comment #12
tim.plunkettAh yes, I didn't see that in the test coverage. Your patch is clearly better :)
Comment #13
dawehner#9: vdc-1909878-8.patch queued for re-testing.
Comment #14
Dries CreditAttribution: Dries commentedCommitted #8 to 8.x. Thanks.
Comment #15.0
(not verified) CreditAttribution: commentedUpdated issue summary.