Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I think it totally makes sense to replace views_get_handler() by a method on the plugin manager, which then can get the views data injected properly.
Comment | File | Size | Author |
---|---|---|---|
#20 | 1907902-20.patch | 24.47 KB | damiankloip |
#17 | drupal-1907902-17.patch | 24.47 KB | dawehner |
#13 | drupal-1907902-13.patch | 17.5 KB | dawehner |
#11 | drupal-1907902-11.patch | 15.09 KB | dawehner |
#11 | interdiff.txt | 638 bytes | dawehner |
Comments
Comment #1
dawehnerLet's see whether this passes all tests.
Comment #3
dawehner#1: drupal-1907902-1.patch queued for re-testing.
Comment #5
dawehnerFixed some bugs, though there is a single problem: The DefaultFactory puts the discovery method into the plugin, so it is not serializeable anymore, just because we now store the viewsDataCache in there.
Comment #7
dawehnerSo the problem is that now the form state contains a db connection, as plugins stores it's manager which gets the views data cache with this patch.
One idea was to use the ViewStorage in the views form (see attached patch), though this does not help, as we need to executed view in order to construct the form.
Comment #8
dawehner.
Comment #9
dawehnerLet's do it.
Comment #11
dawehnerForgot to include joins
Comment #13
dawehnerRerolled.
Comment #15
dawehner#13: drupal-1907902-13.patch queued for re-testing.
Comment #16
damiankloip CreditAttribution: damiankloip commentedI think we should call this $handler_type
Fetches/Gets
nitpcik alert: full stops...
Are we actually using this anywhere atm?
Much nicer :)
Didn't you replace all the calls to this in the patch anyway?
Comment #17
dawehnerYes we do for groupby handlers.
No all are converted.
Comment #18
dawehner#17: drupal-1907902-17.patch queued for re-testing.
Comment #20
damiankloip CreditAttribution: damiankloip commentedSubject to passing, this looks good. Just rerolled as reviewing (straight forward reroll).
Comment #21
dawehnerThank you!!
Comment #22
alexpottCommitted aa56ce3 and pushed to 8.x. Thanks!
Removed unnecessarily added use statement during commit.
Comment #23
Dries CreditAttribution: Dries commentedCommitted to 8.x. Thanks!
Comment #25
xjmComment #26
Chris Matthews CreditAttribution: Chris Matthews as a volunteer and at City of Oaks Design commentedFor more information as to why this issue was moved to the Drupal core project, please see issue #3030347: Plan to clean process issue queue
Comment #27
Chris Matthews CreditAttribution: Chris Matthews as a volunteer and at City of Oaks Design commentedMoving back to the contributed Views issue queue and closing as outdated per https://www.drupal.org/project/views/issues/3030347#comment-13023447