The tests for entity reference views plugins should be part of entity_reference.

CommentFileSizeAuthor
#1 drupal-1906448-1.patch898 bytesdawehner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

Status: Active » Needs review
FileSize
898 bytes

Status: Needs review » Needs work
Issue tags: -Entity Reference, -VDC

The last submitted patch, drupal-1906448-1.patch, failed testing.

dawehner’s picture

Status: Needs work » Needs review
Issue tags: +Entity Reference, +VDC

#1: drupal-1906448-1.patch queued for re-testing.

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community
amitaibu’s picture

This is something we actually did on purpose. Since Views and ER are both in core, there's no longer the notion of "who is more important" like in contrib. So in this case Views is really testing it's own implementation for ER.

webchick’s picture

Status: Reviewed & tested by the community » Needs review

Sounds like that's a needs review, or possibly a won't fix.

dawehner’s picture

This is something we actually did on purpose. Since Views and ER are both in core, there's no longer the notion of "who is more important" like in contrib. So in this case Views is really testing it's own implementation for ER.

So I think the tests should be at the place where the code exists. Here entity reference places it's views plugins in it's own module.
We currently put the (node|user|...) specific tests/views plugins already in the module folder, so this patch just applies how every other piece does it.

amitaibu’s picture

Status: Needs review » Reviewed & tested by the community

Ok, back to RTBC

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.