There are unnecessary variables being used in the comment threading code.

The attached patch simplifies things.

CommentFileSizeAuthor
#4 patch.txt2.02 KBwebernet
#3 patch.txt2.02 KBwebernet
patch.txt2.04 KBwebernet
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chx’s picture

chx CreditAttribution: chx commented

good but Count Zero :) is written as while ($div--)

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs review » Needs work

CNW then.

webernet’s picture

webernet CreditAttribution: webernet commented
Status: Needs work » Needs review
FileSize
patch.txt2.02 KB
webernet’s picture

webernet CreditAttribution: webernet commented
FileSize
patch.txt2.02 KB

Slightly safer.

chx’s picture

chx CreditAttribution: chx commented
Status: Needs review » Reviewed & tested by the community

Yay simpler code! Works. Thanks!

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks. :-)

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.