Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
As pointed out in http://drupal.org/node/1757564#comment-7001904 the wrong config key is used by a mistake.
Comment | File | Size | Author |
---|---|---|---|
#7 | drupal-1903410-7.patch | 4.55 KB | dawehner |
#3 | interdiff.txt | 792 bytes | dawehner |
#3 | drupal-1903410-3.patch | 4.55 KB | dawehner |
#1 | drupal-1903410-tests.patch | 4.1 KB | dawehner |
#1 | drupal-1903410-1.patch | 4.66 KB | dawehner |
Comments
Comment #1
dawehnerAdapted the existing tests, but yeah if you want to be strict there is a lot to be testet.
Comment #2
damiankloip CreditAttribution: damiankloip commentedI think we need to lose the _ again.
'Tests the rendered feed output' or something instead?
This stuff is getting insanely long and ugly, but hey, that's not your fault!
Otherwise, all the tests look fine.
Comment #3
dawehnerThank you for the review, hard to get one these days.
Comment #4
olli CreditAttribution: olli commented#3 solves the problem, adds coverage and fixes #2.
Maybe DefaultViewsTests could test rendering the views too.
Comment #5
catch#3: drupal-1903410-3.patch queued for re-testing.
Comment #7
dawehnerRerole.
Comment #9
dawehner#7: drupal-1903410-7.patch queued for re-testing.
Comment #10
olli CreditAttribution: olli commentedComment #11
Dries CreditAttribution: Dries commentedCommitted to 8.x. Thanks.