I see http://localhost:8888/installer/install.phpadmin/settings/clean-urls/check called in my logs on fresh out of the box, English installs of the latest Drupal 6.x-dev.

This seems to be tied to Drupal.behaviors.cleanURLsSettingsCheck passing through to the AJAX request when it should not do through the installation. I tracked down the error happening on the "Drupal installation complete" page, which is due to the configure form being submitted when this page was generated and the form definition function *itself* includes the JavaScript code, so the JavaScript runs on the page where it was submitted.

The solution is to move the JavaScript code to exactly where it is decided that the form should indeed be displayed and otherwise don't run these stuff. It solves the problem for me perfectly, the form still works with all JavaScript there and there are no 404 messages in my log.

Reviews welcome.

CommentFileSizeAuthor
#8 fix.installer.404_2-190206.patch2.91 KBPasqualle
#2 fix.installer.404.patch2.9 KBGábor Hojtsy
fix.installer.404.patch2.9 KBGábor Hojtsy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented

This patch makes total sense to me. No time to test it, but I agree with the method.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
FileSize
fix.installer.404.patch2.9 KB

Great. I noticed in the meantime, that my st() to t() conversion tests affected this patch. Now attached the original version which uses st() as it should. Same code, just t() calls replaced by st() to match the moved code.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

I think this is a very simple and straightforward patch. Anybody to test?

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

How to reproduce:

- install Drupal normally
- go to your reports (latest log items)
- see a 404 error report on the bogus install.phpadmin/settings/clean-urls/check URL not found

How to fix:

- apply the patch
- do the same as above
- error does not show up

Pasqualle’s picture

Pasqualle
Location 🇭🇺 Budapest
CreditAttribution: Pasqualle commented

I can't see a 404 error report inside "Recent log entries" at fresh Drupal 6.x-dev install.
My server does not support clean-urls. Is it necessary for testing?

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

Yes, forgot to mention that the server should support clean URLs, or otherwise install.phpadmin/settings/clean-urls/check will not end up in the Drupal error report. It will end up in the webserver error report file for non-clean URL installs though. So you can look there. After the patch applied, this error should not appear there.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

Pasqualle, can you please test again?

Pasqualle’s picture

Pasqualle
Location 🇭🇺 Budapest
CreditAttribution: Pasqualle commented
FileSize
fix.installer.404_2-190206.patch2.91 KB

reroll
&testing..

Pasqualle’s picture

Pasqualle
Location 🇭🇺 Budapest
CreditAttribution: Pasqualle commented
Status: Needs review » Reviewed & tested by the community

I had no luck with the server logs, so I reconfigured the server to support clean-urls.

Now I can see the page not found error in the Recent log entries.
The error does not show up after applying the patch..

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Reviewed & tested by the community » Fixed

Great, thanks. Committed.

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.