Followed/related to #1900962: Use Config Entity query for views_get_applicable_views(). We can use this for these functions pretty easily.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

damiankloip’s picture

FileSize
1020 bytes

Oops, we want to return entities.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

RTBC once it's green. YEAH

Status: Reviewed & tested by the community » Needs work
Issue tags: -VDC

The last submitted patch, 1901076-1.patch, failed testing.

dawehner’s picture

Status: Needs work » Needs review
Issue tags: +VDC

#1: 1901076-1.patch queued for re-testing.

damiankloip’s picture

Status: Needs review » Reviewed & tested by the community

This was rtbc already. It's a small patch...

damiankloip’s picture

Issue tags: -VDC

#1: 1901076-1.patch queued for re-testing.

Status: Reviewed & tested by the community » Needs work
Issue tags: +VDC

The last submitted patch, 1901076-1.patch, failed testing.

tstoeckler’s picture

Suppose this needs to be updated for the new status property on views, i.e.

-->condition('disabled', FALSE)
+->condition('status', TRUE)

(and vice-versa).

damiankloip’s picture

Assigned: Unassigned » damiankloip

Yep. Just wanted to make sure ;) I'll reroll this.

damiankloip’s picture

Status: Needs work » Needs review
FileSize
790 bytes
1016 bytes

good to go.

damiankloip’s picture

Assigned: damiankloip » Unassigned
dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Back to RTBC if the patch got green.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1901076-10.patch, failed testing.

tstoeckler’s picture

Status: Needs work » Reviewed & tested by the community

Quick question as a total Views noob: Should we remove the 'views_view_is_(en|dis)abled()' functions as well in this patch or are they use elsewhere? Since they seem to take a $view object, it seems they could just do $view->enabled() now, but I don't know how often that is currently used, i.e. whether it would make sense to do that in a follow-up.

dawehner’s picture

#10: 1901076-10.patch queued for re-testing.

tstoeckler’s picture

Status: Reviewed & tested by the community » Needs work

Crosspost with the machine...

tstoeckler’s picture

Status: Needs work » Reviewed & tested by the community

Again?! Back to RTBC for the bot.

dawehner’s picture

Let's do that in a follow up, but I agree with you that we don't need all those custom functions, people will be used to check the status directly on the entity.

tim.plunkett’s picture

I believe the procedural functions are used by Drush, but now that Views is in core, they can handle that. We should open a Drush issue to coordinate their removal (in a follow-up)

damiankloip’s picture

Yeah. The is enabled and disabled methods were just wrappers added for drush. So we can put anything we need in there now. Good plan!

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 8.x, will push after testbot calms down. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.