Convert views to use the ModuleHandler

This should atleast help a bit. I'm thinking maybe we should get the module handler when the view instance is created? or in build or something, and store it?

Sorry, this patch. Interdiff is still good.

Oh, and that hook is not right.

Ok, now I just need to move the $module_handler var out of the if/else conditional.

We could convert the there stuff to use this too..

Missed the post render theme hooks.

So maybe we shoudl also pass the module handler into the executable from the container as this is a service now.

Here is a patch that does that too. So ViewExecutableFactory now passes the module handler to the ViewExecutable instance.

I think that is what we want now?

Fine! There you go ;)

+++ b/core/modules/views/lib/Drupal/views/Tests/ViewTestData.phpundefined
index 898503f..7956546 100644
--- a/core/modules/views/lib/Drupal/views/ViewExecutable.php

--- a/core/modules/views/lib/Drupal/views/ViewExecutable.php
+++ b/core/modules/views/lib/Drupal/views/ViewExecutable.phpundefined

+++ b/core/modules/views/lib/Drupal/views/ViewExecutable.phpundefined
+++ b/core/modules/views/lib/Drupal/views/ViewExecutable.phpundefined
@@ -978,10 +978,8 @@ public function build($display_id = NULL) {

@@ -978,10 +978,8 @@ public function build($display_id = NULL) {
     }
 
     // Let modules modify the view just prior to building it.
-    foreach (module_implements('views_pre_build') as $module) {
-      $function = $module . '_views_pre_build';
-      $function($this);
-    }
+    $module_handler = drupal_container()->get('module_handler');
+    $module_handler->invokeAll('views_pre_build', array($this));
 
     // Attempt to load from cache.
     // @todo Load a build_info from cache.
@@ -1102,10 +1100,7 @@ public function build($display_id = NULL) {

Can't ViewExecutable get this from the constructor?

Also I'm hoping #1875086: Improve DX of drupal_container()->get() can go in soon, this will need a re-roll once that's in.

#26: 1895266-26.patch queued for re-testing.

rerolled.

Needed another reroll after ViewsDataCache changes for DestructionInterface.

Annnd, back to RTBC again.

#37: drupal-1895266-37.patch queued for re-testing.

Needs a re-roll now that #1937600: Determine what services to register in the new Drupal class has landed

Rerolled to use Drupal::moduleHandler()

Rerolled, the ViewsDatCache patch got in..

Oops sorry, I stuffed up the merge slightly in ViewsDataCache!

+++ b/core/modules/views/lib/Drupal/views/ViewsDataCache.phpundefined
@@ -40,6 +41,13 @@ class ViewsDataCache implements DestructableInterface {
+  /**
+   * The current language code.
+   *
    * @var array
    */
   protected $requestedTables = array();

Seems the merge of ViewsDataCache is still slightly stuffed :)

+++ b/core/modules/views/lib/Drupal/views/ViewsDataCache.phpundefined
@@ -67,14 +75,32 @@ class ViewsDataCache implements DestructableInterface {
+  protected $rebuildCache;

Unused property...

The ViewsDataCache class was all messed up :) Let's try this.

I think that we also need to replace the following calls into module_* as well.

if (!is_dir($config_dir) || !module_exists($module)) {
  continue;
}

In \Drupal\views\Tests\ViewTestData...

module_load_include('inc', 'views_ui', 'admin');

In Drupal\views\Plugin\views\wizard twice... The module_handler service has a loadInclude() method which performs the same task. Hmmm... although this plugin is provided by views so views ui might not be enabled???

module_load_include('inc', 'views', 'views.theme');

In views.module twice...

module_load_include('inc', 'views_ui', 'admin');

in Drupal\views\Tests\ViewsDataTest should use $this->container->get('module_handler')...

$implementations = module_implements($hook);

In Drupal\views\Tests\ViewsHooksTest should use $this->container->get('module_handler')...

module_load_include('inc', 'views_ui', 'admin');

In Drupal\views\tests\UI\TagTest should use $this->container->get('module_handler')...

    module_load_include('inc', 'views_ui', 'admin');
    module_load_include('inc', 'views', 'includes/ajax');

In Drupal\views_ui\Form\Ajax\ViewsFormBase... this FormInterface probably should have the container injected and use it....

in Drupal\views\Tests\ViewsDataTest should use $this->container->get('module_handler')...

See #1914256: Add all views hooks to hook_hook_info()

Fixing the other things now.

I have made the other change, I have only converted the usage in the ajax form base, as there is a todo to remove them anyway.

Oh dear, I think I see what's going on here, these are failing because of how moduleHandler works :( If the module isn't enabled, it can't include the file. So we need to enable views_ui for those 2 tests.

Really bored of this issue now :)

This is back to RTBC, just reverting a change that shouldn't be there.

Committed 12b09da and pushed to 8.x. Thanks!