In order to require area handlers to implement the render method, as it's always helpful
this method should be marked as abstract.

CommentFileSizeAuthor
#3 views-1893844-3.patch1.16 KBno_commit_credit
#1 drupal-1893844-1.patch1.17 KBdawehner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Active » Needs review
FileSize
drupal-1893844-1.patch1.17 KB
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented 
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/area/Title.phpundefined
@@ -58,4 +58,12 @@ public function preRender(array $results) {
+  /**
+   * Implements \Drupal\views\Plugins\views\area\AreaPluginBase::render();
+   */
+  public function render($empty = FALSE) {
+    // Do nothing for this handler.
+  }
+
+
 }

Extra blank line at the end there.

no_commit_credit’s picture

no_commit_credit CreditAttribution: no_commit_credit commented
FileSize
views-1893844-3.patch1.16 KB

Just removing the extra blank line.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

So that's RTBC?

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented

That looks just fine to me.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.