Views had it's own handling of autocompletion for user, though since #1817656: Let user_autocomplete also find the anonymous user. that's not needed anymore.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

Status: Active » Needs review
FileSize
4.74 KB

Yeah!

dawehner’s picture

FileSize
4.75 KB

New version.

damiankloip’s picture

Status: Needs review » Reviewed & tested by the community

That is a great diff!

olli’s picture

Status: Reviewed & tested by the community » Needs work
+++ b/core/modules/user/lib/Drupal/user/Plugin/views/filter/Name.php
@@ -45,7 +45,7 @@ function value_form(&$form, &$form_state) {
+      '#autocomplete_path' => 'user/autocomplete?anonymous=1',

Autocomplete path does not seem to work with that query part.

+++ b/core/modules/views/includes/ajax.inc
@@ -279,53 +279,6 @@ function views_ajax_form_wrapper($form_id, &$form_state) {
-  // The user enters a comma-separated list of user name. We only autocomplete the last name.

I think user/autocomplete does not support that. Am I missing something?

dawehner’s picture

Mh damnit, you are probably right in both cases ... we will have to figure them out.

alexpott’s picture

Status: Needs work » Needs review
FileSize
4.75 KB

Couldn't resist a re-roll now #1817656: Let user_autocomplete also find the anonymous user. is done in a way that'll work!

But considering #2 actually passed maybe we need a test?

tstoeckler’s picture

Status: Needs review » Reviewed & tested by the community

RTBC in case it comes back green.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Rock, thanks!

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.