Follow up for #1848490: Import translations automatically during installation
Problem/Motivation
$ drush -y si --account-pass=admin --db-url="mysql://root:root@localhost/d8-git" --site-name=8.x
You are about to create a sites/default/files directory and create a sites/default/settings.php file and DROP all tables in your 'd8-git' database. Do you want to continue? (y/n): y
Starting Drupal installation. This takes a few seconds ... [ok]
Installation complete. User name: admin User password: admin [ok]
Strict warning: Only variables should be passed by reference in [error]
install_select_language() (line 1344 of
core/includes/install.core.inc).
Proposed resolution
TBD.
Remaining tasks
Decide if this is an install problem or a drush one.
User interface changes
No UI changes.
API changes
Maybe parameter type changes.
Comment | File | Size | Author |
---|---|---|---|
#5 | 1889720.5.patch | 529 bytes | alexpott |
#3 | drupal-nonvariable_by_ref-1889720-3.patch | 1 KB | YesCT |
Comments
Comment #1
YesCT CreditAttribution: YesCT commentedComment #2
YesCT CreditAttribution: YesCT commentedComment #3
YesCT CreditAttribution: YesCT commentedAlso, the @return is missing typing. maybe should be array|null
And start the description with "Returns nothing or for interactive..."
But that is not related to this issue and should be a sep clean up issue probably.
Without any patch, even though drush says [error] the site looks to be installed ok. Maybe it's passing along an exception?
About the patch: I actually dont know if this will help at all. Local testing still give the error.
Comment #4
YesCT CreditAttribution: YesCT commentedComment #5
alexpottGetting this myself... but the fix seems to be in a different place... line 1344 is:
The issue is explained by http://stackoverflow.com/questions/6698428/return-first-key-of-associati... basically:
Comment #6
alexpottps. this is the only place in the entire codebase where I can find "array_shift.*array_key"
pps. the current(array_keys()) trick is used only in one place too :) Drupal\Core\Entity\Field\Type\Field::setValue()
Comment #7
tim.plunkettI don't think this needs a test of its own, it doesn't actually break anything. Just a notice.
Comment #8
webchickCommitted and pushed to 8.x. I don't think it's possible to test anything in the installer, unfortunately.