Similarly to #1867096: Rewrite RdfaMarkupTest to parse RDFa, we should also update TrackerAttributesTest to use easyrdf to parse the RDFa output and verify that the output is what we expect.

This issue depends on the easyrdf library: #1866858: Test RDFa by parsing RDFa (add the easyrdf library).

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

scor’s picture

Status: Active » Needs work
FileSize
1.51 KB

Here is a start (the easyrdf library is not included in this patch).

scor’s picture

Status: Needs work » Needs review
FileSize
8.35 KB

this should cover all the tests. still using the standard profile at the moment.

Anonymous’s picture

Status: Needs review » Needs work

We can remove the dependence on standard profile by:

  1. Removing 'rdf_test', which isn't actually necessary for the test.
  2. Adding a call to drupalCreateContentType to create the article content type, like AggregatorTestBase does.

EDIT: actually, removing rdf_test probably isn't necessary, but should be done anyway since it isn't really required.

scor’s picture

Status: Needs work » Needs review
FileSize
3.34 KB
10.24 KB

- removed dependency on standard profile by creating the article content type in setUp()
- removed rdf_test dependency
- moved base_uri in setUp()

scor’s picture

oops, forgot to fix the 'definition of' -> 'Contains' at the beginning as well. will wait for more comment to roll a new patch. keep this needs review for now.

scor’s picture

also improved the code to fetch last activity date from the db.

Anonymous’s picture

Status: Needs review » Reviewed & tested by the community

Looks good, thanks!

Like the comments test update which was committed yesterday, this removes the dependency on standard profile and makes the tests more accurate by actually parsing RDFa.

catch’s picture

Status: Reviewed & tested by the community » Fixed

Looks great. Committed/pushed to 8.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.