Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Similarly to #1867096: Rewrite RdfaMarkupTest to parse RDFa, we should also update TrackerAttributesTest to use easyrdf to parse the RDFa output and verify that the output is what we expect.
This issue depends on the easyrdf library: #1866858: Test RDFa by parsing RDFa (add the easyrdf library).
Comment | File | Size | Author |
---|---|---|---|
#6 | 1886102_TrackerAttributesTest_6.patch | 10.58 KB | scor |
#6 | interdiff.txt | 2.09 KB | scor |
#4 | 1886102_TrackerAttributesTest_4.patch | 10.24 KB | scor |
#4 | interdiff.txt | 3.34 KB | scor |
#2 | 1886102_TrackerAttributesTest_2.patch | 8.35 KB | scor |
Comments
Comment #1
scor CreditAttribution: scor commentedHere is a start (the easyrdf library is not included in this patch).
Comment #2
scor CreditAttribution: scor commentedthis should cover all the tests. still using the standard profile at the moment.
Comment #3
Anonymous (not verified) CreditAttribution: Anonymous commentedWe can remove the dependence on standard profile by:
EDIT: actually, removing rdf_test probably isn't necessary, but should be done anyway since it isn't really required.
Comment #4
scor CreditAttribution: scor commented- removed dependency on standard profile by creating the article content type in setUp()
- removed rdf_test dependency
- moved base_uri in setUp()
Comment #5
scor CreditAttribution: scor commentedoops, forgot to fix the 'definition of' -> 'Contains' at the beginning as well. will wait for more comment to roll a new patch. keep this needs review for now.
Comment #6
scor CreditAttribution: scor commentedalso improved the code to fetch last activity date from the db.
Comment #7
Anonymous (not verified) CreditAttribution: Anonymous commentedLooks good, thanks!
Like the comments test update which was committed yesterday, this removes the dependency on standard profile and makes the tests more accurate by actually parsing RDFa.
Comment #8
catchLooks great. Committed/pushed to 8.x.