Use context to override ad unit size [#1884052]

Split from: http://drupal.org/node/1866196

A context reaction to override ad unit size, coupled with http://drupal.org/project/context_breakpoint, could provide a neat way of delivering ads on reactive themes.

We have a scenario where we have three buttons the same size in a sidebar, so the ability to select more than one ad unit for this would be helpful.

Thoughts?

Comment	File	Size	Author
#4	1884052.patch	6.43 KB	bleen
#4
#4	Screenshot_1_22_13_4_00_PM.png	72.89 KB	bleen
#3	DFP2.png	148.48 KB	gurrmag
#2	DFP.png	124.46 KB	gurrmag

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

bleen CreditAttribution: bleen commented 13 January 2013 at 14:07

This is something i would definitely consider as long as we found a good way to say "at breakpoint X, set tagA's size to wXh AND tagB's size to wXh ...." The UI here could get very confusing

Comment #2

gurrmag CreditAttribution: gurrmag commented 14 January 2013 at 10:08

File	Size
DFP.png	124.46 KB

I was thinking breakpoints+context-breakpoint to provide a context condition that effectively looks to see if a media query set in breakpoints is satisfied - see attached.

Comment #3

gurrmag CreditAttribution: gurrmag commented 14 January 2013 at 10:40

File	Size
DFP2.png	148.48 KB

Very rough mock-up of UI following that of existing context plugin for DFP - not sure if tokens are necessary though?

Comment #4

bleen CreditAttribution: bleen commented 22 January 2013 at 21:03

Status:

Active

» Needs review

File	Size
Screenshot_1_22_13_4_00_PM.png	72.89 KB
1884052.patch	6.43 KB

This patch should work really well (especially with a module like context_breakpoint for example) and should allow users to override the size of ads.

Comment #5

gurrmag CreditAttribution: gurrmag commented 23 January 2013 at 20:51

That's great... Thanks for looking at this so quickly...

I'll look at this as soon as I can...

Comment #6

bleen CreditAttribution: bleen commented 23 January 2013 at 21:01

Thanks ... the sooner the better - I'm ramping up to do an official release of DFP :)

Comment #7

gurrmag CreditAttribution: gurrmag commented 24 January 2013 at 09:58

I can confirm this works... Looking forward to an official release!

In case anyone else decides to go down this path, it may be worth just cross-posting this issue/patch on context_breakpoints which means, on some browsers, the context using breakpoints will not fire the first time someone visits the site (i.e. cleared cookies): Current context is not checked against existing cookie when page is loaded, so, without applying the patch at #1 there, you may get either no ads or ads of the wrong size the first time you visit the site.