Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
This patch moves the textarea hook for 'pre' between the title and the textarea. This makes it easier for simply textarea enhancements like quicktags to add a toolbar just above the textarea. It doesn't appear to have any effect on the fckeditor or htmlarea modules. It doesn't introduce any new hooks.
Comment | File | Size | Author |
---|---|---|---|
#9 | textarea_updated.patch | 1.97 KB | TDobes |
#7 | textarea.patch | 1.88 KB | Dries |
common.inc_10.patch | 1.8 KB | jbond | |
Comments
Comment #1
killes@www.drop.org CreditAttribution: killes@www.drop.org commentedGuess that is a patch.
Comment #2
Bèr Kessels CreditAttribution: Bèr Kessels commented+1 From me.
Any module that adds something, will want to add it after the title. I really cannot think of any case where aditional content should sit above the title, but I can think of loads of cases where content needs to sit between the title and textarea.
Comment #3
Stefan Nagtegaal CreditAttribution: Stefan Nagtegaal commentedIndeed, nice and simple patch! +1 from me either..
Comment #4
jbond CreditAttribution: jbond commentedhttp://www.voidstar.com/node.php?id=2263
If this patch gets accepted I'll drop this into contrib. It's similar to quicktags but *I* like it better. ;-)
Comment #5
TDobes CreditAttribution: TDobes commented+1... I'm pretty sure the current positioning was accidental anyway... it was always meant to go directly above the textarea.
Comment #6
Bèr Kessels CreditAttribution: Bèr Kessels commentedDries,
All people who use this, seem to agree. Any chance this gets in soon?
Bèr
Comment #7
Dries CreditAttribution: Dries commentedBer: while all people seem to agree, it is unclear how many people tested/reviewed this patch. One ought to be careful. For example, the patch introduces a new variable, $form_element, without properly initializing it ...
How about the attached patch? It is slightly cleaner, slightly faster and properly initializes all variables. I haven't tested it with the WYSIWYG editors but maybe someone else (Julian?) can? Will commit after it has been tested.
Comment #8
Dries CreditAttribution: Dries commentedAnyone to test this?
Comment #9
TDobes CreditAttribution: TDobes commentedThe patch no longer applied, so I updated it. I also tested it with:
* Quicktags
* TinyMCE
* Areatags (mentioned earlier by jbond)
It worked with all three... +1 for applying Dries' cleaner patch.
jbond: Your module's browser detection code does not work on my server. You seem to expect a $HTTP_USER_AGENT global variable, which does not exist... I think you should instead be using $_SERVER['HTTP_USER_AGENT']. Perhaps your code was created with the assumption that "register_globals" is turned on in php.ini? That setting is off by default, so I wouldn't rely on it.
Comment #10
Dries CreditAttribution: Dries commentedCommitted to HEAD. Thanks.
Comment #11
Dries CreditAttribution: Dries commentedComment #12
(not verified) CreditAttribution: commented