Cannot add new filter group

To meet the coding style of the other parts, this seems to fit better.

Related ? #1875632-13: JS settings merging behavior: preserve integer keys (allow for array literals in drupalSettings)

The undefined thing is causing errors because of "use strict"; it will error out if there are implicit global variables declared, like here.

@nod_

Which of the two approaches is the way to go forward on this issue?

for the sake of consistency it should be #1 although I agree that ideally #3 would be the prefered format.

so I'd say #1 and if we get around fixing the declaration it should be for all of core js.

tags

Well, there are more then just two different for loops in this file so 1) might actually be less consistent.

oh that's true, I was looking at the rest of core but in this file it's different. Views js needs love anyway so either works, I don't mind.

To be honest, personally I really prefer the #1 style, as it's more consistent with the rest of Drupal core, so basically let's do that.

Hmm I like #3 better :P

Is the issue to consolidate this open already? I'll commit whichever patch once it is.

I guess we simply can't decide it: Either throw a coin or just use #3 as you liked it better :)

So #3 is better :)

Committed and pushed to 8.x. Thanks!