There is a text called "If set to normal or tab, enter the text to use for the menu item.", it seems to give the idea that when you select either normal or tab you must enter a value here. But they are the only values available, as contrib adds options here the text might even not be valid anymore. Therefor I would suggest to streamline the descriptions here with that of Core menu link adding.
Before
After
I also removed something that wasn't RTL friendly.
Further improvements could include:
1) Use states, to display these fields "below" not next to the radio's so it doesn't create an often awkward small area to configure within.
2) Use more sensible labels than "normal", "tab" - as especially the "tabs" are confusing options - since they don't have to be themed that way.
3) Make the description into a textarea, just like Core.
Comment | File | Size | Author |
---|---|---|---|
#6 | longest_description_ever.png | 24.18 KB | dawehner |
simplify-menu-entry-text.patch | 2.85 KB | Bojhan | |
normal-menu-entry-after.png | 27.57 KB | Bojhan | |
normal-menu-entry-before.png | 33.18 KB | Bojhan |
Comments
Comment #1
dawehnerThe title textfield is only hidden when you have "none" selected.
It seems to be that you missed one place: Therefore select first "Default menu tab" and then you will get a lot of additional settings/descriptions.
Comment #2
Bojhan CreditAttribution: Bojhan commentedAh, I can't seem to get to that "Default menu tab" text - heh. Any pointers?
Comment #3
dawehnerSelect "default menu tab", click "apply" and you will see another configuration screen and an additional link beside the previous menu settings link.
Comment #4
Bojhan CreditAttribution: Bojhan commentedI am looking into this.
Comment #5
Bojhan CreditAttribution: Bojhan commentedHaving looked into this, I dont see these labels repeating, I only see loads of descriptions above - we can fix that here or in a new issue, whatever is best.
Comment #6
dawehnerFor other people this was what I have been talking about, let's fix that in another issue.
In contrast to the settings these changes are not that controversial.
Comment #7
webchickI got confused thinking #6 was the improvement and was like "Buh??" :) The "After" in the OP looks good.
Committed and pushed to 8.x. Thanks!