#1810386: Create workflow to setup multilingual for entity types, bundles and fields added the translation entity interface, it's js isn't following newer core standards for it.

Declared and attached the JS with hook_library_info(), used event delegation on the admin screen so that it'll somehow scale for real sites. It's still not good enough though.

The table UI is bad from a code perspective, it shouldn't be using tables or at least it needs classes to be added on cells to make all those selectors much faster to match. Not really in the scope of this issue i'd say.

CommentFileSizeAuthor
core-js-te.patch4.38 KBnod_
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nod_’s picture

Status: Active » Needs review
Wim Leers’s picture

Status: Needs review » Reviewed & tested by the community

All of this is functionally identical, with better performance thanks to delegation instead of binding.

Note: I didn't test this manually, but I'm assuming nod_ did since he wrote it.

nod_’s picture

I did test it :)

Wim Leers’s picture

Issue tags: +JavaScript
Gábor Hojtsy’s picture

Issue tags: +D8MI, +sprint

Add sprint tag and D8MI for easier tracking.

Wim Leers’s picture

LOL, in #4 I added the "JavaScript" tag, but now that change is no longer being rendered. WTF, d.o!?

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Gábor Hojtsy’s picture

Issue tags: -sprint

Superb, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.