Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.When we added Guzzle, we had to use a git clone based version that included the very latest commits as there were required composer.json changes in Guzzle.
Since then, 3.0.6 and 7 have been released, containing these changes, so it should be save to go back to a version definition of "3.0.*@stable" or similar.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | guzzle-easyrdf-update-1875818-8.patch | 99.72 KB | Berdir |
| #3 | guzzle-update-1875818-3.patch | 74.13 KB | Berdir |
| #1 | guzzle-update-1875818-1.patch | 26.74 KB | Berdir |
| #1 | guzzle-update-1875818-1.patch | 26.74 KB | Berdir |
Comments
Comment #1
BerdirAnother reason for this.
It was impossible to call composer update guzzle/http because composer died with a Runtime exception about a missing composer remote. I guess it assumed the existence of a .git repository within the guzzle directories, so I had to completely remove vendor/guzzle first.
Should otherwise be a straight forward thing to do...
Comment #3
BerdirHah, or so you'd think.
Looks like the update introduced a dependency on the backoff plugin, which is however not defined in composer.
For demonstration purposes, I added it manually and confirmed that the tests then work again. But that adds a plugin that we don't need and also the Log component.
I think this shouldn't be hard dependency and CurlMulti.php should check the existence of that plugin...
Will open an upstream bug report.
Comment #4
BerdirOpened https://github.com/guzzle/guzzle/issues/196
Comment #5
BerdirThe bug has been fixed but now we need to wait for 3.0.8 :)
Comment #6
YesCT CreditAttribution: YesCT commentedrelated: #1599622: Run poormanscron via a non-blocking HTTP request
Comment #7
BerdirHm, weird. Looks like that easyrdf stuff was renamed and we reference a version that does not exist?
Was not able to update just guzzle and ignore easyrdf and easyrdf seems to contain huge changes, a ton of test files, ... ?
Comment #8
BerdirOk, here is an update with easyrdf set to dev-master. Looks like most of the files are identical. Not sure if that is correct, we can always update that again.
I left the LICENSE and similar files in there, I think they might be relevant for licensing reason.
Comment #9
scor CreditAttribution: scor commentedthanks @Berdir, this update to easyrdf is fine, I think I used the wrong namespace in composer.json before. We will most likely update easyrdf in the future to keep up with its changes, so we can fine tune as necessary.
Comment #10
YesCT CreditAttribution: YesCT commentedIf there is no manual test to do, I think this is RTBC.
@scor thought this looked ok.
The code changes look reasonable (they come from the new/updated files).
And the testbot is green.
Comment #11
webchickCommitted and pushed to 8.x. Thanks!