"Block Library" link label is unclear [#1874584]

Problem/Motivation

This is a followup issue for #1535868: Convert all blocks into plugins.

On admin/structure/block, the purpose of the "Block library" local action link is unclear and does not make sense out of context (for translation, accessibility, etc.)
"Block Library" is the label provided for BlockPluginUI in its annotation, and the PluginUI API apparently provides this local action automatically.

Proposed resolution

Change the link text to "Add block".
Decide if the annotation label should be changed directly, or if the link should be altered, or if the way the link is added by the plugin UI should be changed in general.

Remaining tasks

Related issues

Comment	File	Size	Author
#4	block-label-1874584-4.patch	642 bytes	kim.pepper
#4

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

xjm

she/her

English

CreditAttribution: xjm commented 4 January 2013 at 17:21

Status:

Postponed

» Active

Comment #2

Bojhan CreditAttribution: Bojhan commented 4 January 2013 at 21:24

Assigned:

Unassigned

» Bojhan

Makin patch

Comment #3

xjm

she/her

English

CreditAttribution: xjm commented 13 January 2013 at 20:37

Issue tags:

+Block plugins

Comment #4

kim.pepper

English

🏄‍♂️🇦🇺Sydney, Australia

CreditAttribution: kim.pepper commented 16 January 2013 at 02:48

Assigned:	Bojhan	» kim.pepper
Status:	Active	» Needs review

File	Size
block-label-1874584-4.patch	642 bytes

I've attached a simple patch that renames the title from "Block Library" to "Add block".

Comment #5

Bojhan CreditAttribution: Bojhan commented 16 January 2013 at 16:10

Status:

Needs review

» Reviewed & tested by the community

Sorry, somehow this fell of my radar. RTBC

Comment #6

Dries CreditAttribution: Dries commented 16 January 2013 at 16:22

Do we want to leave the other references to 'library' in the UI/URLs?

Comment #7

droplet CreditAttribution: droplet commented 16 January 2013 at 16:28

Add Block is unclear. First glance at the page, I'd think "Add Block" == "Add Custom Block"

Comment #8

Bojhan CreditAttribution: Bojhan commented 16 January 2013 at 16:43

@droplet from my pov, is that simply a legacy thing. I dont think many new users will be confused, nor would it be a big hump for exciting users and its more consistent with local actions in general.

Comment #9

webchick

she/they

English

Vancouver 🇨🇦

CreditAttribution: webchick commented 16 January 2013 at 17:28

Status:

Reviewed & tested by the community

» Fixed

Yes, please.

I clicked around and didn't notice any other references to the term "block library," so I think we're good there.

Committed and pushed to 8.x. Thanks!

Comment #10

30 January 2013 at 17:30

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Comment #11

YesCT CreditAttribution: YesCT commented 29 March 2013 at 22:36

while discussing my clock confusion in irc, the concept of a block library was helpful.
Not having the button named library and having the 'Add block' button is good.
But
#1956362: Name the page that lists block plugins, now: Blocks and Add Blocks, better: Block Library
considers what to name the page that the 'Add block' button leads to.