Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.We don't need/can't have the advanced settings for devel output anymore. Also, they are also not being used ANYWHERE anymore :)
I think we discussed a while ago, we also probably want to remove the setting to disable javascript just for views UI?
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | drupal-1873342-5.patch | 2.33 KB | dawehner |
| vdc-remove-settings.patch | 3.73 KB | damiankloip | |
Comments
Comment #1
Bojhan CreditAttribution: Bojhan commentedYes, +1 for all of this. I don't like UI settings at all, because it tends to be for "very" expert users. Views in core should be lean and rely more heavily on contrib, for this kind of functionality.
Comment #2
aspilicious CreditAttribution: aspilicious commentedSeems ready to me...
Comment #3
dawehnerOh right we just use debug() now.
Comment #4
xjmHang on a second there. I use that disable JS setting all the time. Edit: And right now it's the workaround for using Views without a mouse.
Didn't we discuss this in IRC? And why is the discussion not reflected in this issue?
Also, in general, screenshots.
Comment #5
dawehnerWell, probably a lack of memory :)
Let's skip the javascript change.
Comment #6
xjmOkay, that works for me. :)
Comment #7
damiankloip CreditAttribution: damiankloip commentedI don't see why we need to support this mid way through the development stage? No where else in core uses this pattern of turning off js for one particular admin form. This is weird. I think it should still go.
And screenshots of what? I'm confused...
Comment #8
Bojhan CreditAttribution: Bojhan commentedYhea, I agree. We shouldn't have this, I am not sure we should have a toggle for this - we do in the overlay, but its not fixable there - in the modal views case we have a fix coming up (so we are just jumping ahead, to that fix being in).
Comment #9
damiankloip CreditAttribution: damiankloip commentedComment #10
Bojhan CreditAttribution: Bojhan commentedOk, #5 is RTBC.
I opened an issue to further discuss the disable JS option at #1874528: Remove "disable JS for Views UI" checkbox
Comment #11
Dries CreditAttribution: Dries commentedCommitted to 8.x. Thanks.
Comment #12
xjmI guess we'll want a change notice for the removal of this feature.
Comment #13
xjmComment #14
dawehnerIntroduced one which describes the full space of change: http://drupal.org/node/1875212
Comment #15
xjmThat works for me. I polished the text a little.