Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
#1853522: [META] (Re)introduce Views data integration for core modules
It would make sense to expose the forum index tables to views.
Comment | File | Size | Author |
---|---|---|---|
#28 | 1867642-28.patch | 12.39 KB | damiankloip |
#28 | interdiff-1867642-28.txt | 1.7 KB | damiankloip |
#19 | drupal-1867642-19.patch | 12.03 KB | dawehner |
#19 | interdiff.txt | 483 bytes | dawehner |
#16 | drupal-1867642-16.patch | 11.98 KB | dawehner |
Comments
Comment #1
dawehnerJust some work :)
Comment #2
xjmOops. :)
Uh...?
Comment #3
dawehnerUps.
Comment #4
xjmSince there's a partial patch.
Comment #5
larowlanYes, that would mean a lot of the /forum pages could be default views.
I assume this can go in after Feb?
Comment #6
xjmYep, these integrations are okay after Feb. 18.
Comment #7
andypostmarked as duplicate #309001: Views integration
Comment #8
podarokstatus
Comment #9
xjmActually still NW I think.
Comment #10
Anonymous (not verified) CreditAttribution: Anonymous commentedMay I be... OK, I'm *going* to be as bold as to ask the theory behind keeping Forum in core. Is it because there's many hanging off it already so if we removed it it would cause issues? We removed blog - that's a relief - but after looking at the forum code I really don't know why it's there - surely it's a contrib thing as we need to focus more on making the framework work?
Apologies if just jumping in and saying but I'm getting old and time is running out for me.
Ta
s
Comment #11
damiankloip CreditAttribution: damiankloip commentedThis issue is just about adding views integration for forum, I think whether it should be removed from core or not is a different issue altogether :)
I agree though, and would be pretty happy if I awoke one morning to find forum module gone...
Comment #12
Anonymous (not verified) CreditAttribution: Anonymous commentedCool, thanks for the direction, done:
#1898812: [policy] Deprecate forum module for removal in Drupal 11
Comment #13
damiankloip CreditAttribution: damiankloip commentedWe prob need to chnage these labels.
Likewise.
Comment #14
xjmYep: Node ID, Vocabulary ID.
Comment #15
dawehnerMetadata is probably as bad as "Views properties" :) What about "Edit Name / other basic"?
Comment #16
dawehnerSometimes you are just in the wrong issue :)
Posting a basic test.
Comment #17
andypostNo sort and field definition. Why?
Why this IDs are different?
Comment #18
damiankloip CreditAttribution: damiankloip commentedNot sure exactly what you mean, but we have a numeric filter plugin, but for sorts, the standard is fine.
Comment #19
dawehnerThe reason why I removed the field from there is that this might confuse users, as you don't have enough information available here in order to render a full field, so our approach of using entities doesn't work at all. The only thing we can support is to display the actual number, which does this patch.
Comment #20
podarok#19 looks good and covered with tests
RTBC
Comment #21
xjm#19: drupal-1867642-19.patch queued for re-testing.
Comment #23
dawehner#19: drupal-1867642-19.patch queued for re-testing.
Comment #24
xjmRestoring status.
Comment #25
xjmAnd fixing tags. :)
Comment #26
xjm#19: drupal-1867642-19.patch queued for re-testing.
Comment #27
alexpottFrom IRC
Comment #28
damiankloip CreditAttribution: damiankloip commentedLet's add this to HandlerAllTest, and fix up a couple of small things.
Also, changed human_name to label, but missed that off the interdiff.
Comment #29
dawehnerGreat additions!
Comment #30
alexpottCommitted bc8686e and pushed to 8.x. Thanks!
Assigning to the views queue for change notice and possible backport...
Comment #31
ParisLiakos CreditAttribution: ParisLiakos commentedi think this might have introduce a random failure? actually exception
Edit: Nvm this is a legit one, not random at all, sorry for noise
Comment #32
larowlanAnyone know of an issue to use this for /forum /forum/x I can't find one with google/d.o/email/metas?
Comment #33
mgiffordIs this now a D8 Views issue or should it be a D7 Views issue now that it's committed to D8 Core?
Comment #34
jibranRE: #32 #2207263: Try and build /forum and /forum/{tid} with views
4 years without a change notice I think we are good here. If someone wants to backport it feel free to create a new issue in views queue.