Follow up for #1864292-7: Installation in non-English language fails (See step 5.)

Problem/Motivation

Warning during install when installing in another language
at
core/install.php?langcode=nl&profile=standard

Warning: Invalid argument supplied for foreach() in locale_translation_status_delete_languages() (line 949 of core/modules/locale/locale.module).

i-s05-warning-2012-12-12_0008.png

Proposed resolution

A check if $status exists before it is being processed.

Remaining tasks

Discussion.
Test.

User interface changes

No UI changes anticipated.

API changes

No API changes anticipated.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

YesCT’s picture

Title: Copy of Installation in non-English language fails » Warning when tries to delete English after non-English install, locale_translation_status_delete_languages()
YesCT’s picture

Priority: Critical » Minor
FileSize
78.31 KB

But English is deleted.
admin/config/regional/language
noenglish-2012-12-12_0052.png

Sutharsan’s picture

The code is missing a check before the foreach is started. Note that to manually test test patch, the latest patch in #1864292: Installation in non-English language fails is required too.

Sutharsan’s picture

Status: Active » Needs review

go botty

Gábor Hojtsy’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +language-ui

This only happens on install, so not really possible to do automated tests. Change looks trivial otherwise. Thanks!

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 8.x.

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

updated resolution