Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
All methods have docblocks stating
/**
* Implements EntityAccessControllerInterface::XXX().
*/
should be
/**
* Implements EntityAccessControllerInterface::XXXAccess().
*/
in line with the interface
Comment | File | Size | Author |
---|---|---|---|
#4 | test-access-1864218.3.patch | 1.81 KB | larowlan |
#1 | test-access-1864218.1.patch | 1.73 KB | larowlan |
Comments
Comment #1
larowlanstraight forward
Comment #3
dawehnerActually it should be
Shouldn't it be even\Drupal\Core\Entity::EntityAccessControllerInterface()
Comment #4
larowlansure!
Comment #5
dawehnerThis looks great!
Comment #6
fubhy CreditAttribution: fubhy commentedActually I am pretty sure that we agreed not to have full namespaces there. Which is why we removed them at some point in the other issue. @see http://drupal.org/coding-standards/docs#namespaces
Comment #7
larowlanthe method names are wrong eg they're ::viewAccess() not ::view()
Comment #8
larowlanwhich is patch 1
Comment #9
larowlan#1: test-access-1864218.1.patch queued for re-testing.
Comment #10
larowlanPlease review patch 1
Comment #11
dawehnerI'm not sure as all new patches follow that standard at the moment (at least from my perspective).
Comment #12
BerdirThis is still being discussed back and forth in #1487760: [policy, no patch] Decide on documentation standards for namespaced items. Most patches that I've seen recently don't use the full name if it's in the same namespace. I currently don't really care about that standard, it has been changed a bunch times already and we have dozens of wrong classes that will need to be fixed anyway, doesn't matter what we decide to do now :) Using non-namespaces versions for things that are in the same namespace or use'd sounds fine to me.
Comment #13
dawehnerHe, so all entity related patches work different to all CMI/VDC related patches :)
Let's RTBC patch #1
Comment #14
fubhy CreditAttribution: fubhy commentedOh... Yeah +1 rtbc. I read the issue too quickly sorry. Patch #1 is okay!
Comment #15
Dries CreditAttribution: Dries commentedCommitted to 8.x. Thanks.