Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#13 | xml-rpc-guzzle-1875614-13.patch | 3.89 KB | YesCT |
#13 | interdiff-10-13.txt | 1.08 KB | YesCT |
#10 | xml-rpc-guzzle-1875614-10.patch | 3.86 KB | Berdir |
#2 | xmlrpc-guzzle-1862512-2.patch | 3.53 KB | Berdir |
#2 | xmlrpc-guzzle-1862512-2-interdiff.txt | 603 bytes | Berdir |
Comments
Comment #1
BerdirSeems to be easy enough.
Changed $options to $headers, not an exact conversion but not sure what other options you'd might want to set. Not much possible without refactoring the whole module...
Comment #2
BerdirWe can't rely on $response, see #1862524: Convert drupal_http_request usage in aggregator.module to Guzzle
Comment #4
Berdir#2: xmlrpc-guzzle-1862512-2.patch queued for re-testing.
Comment #6
Berdir#2: xmlrpc-guzzle-1862512-2.patch queued for re-testing.
Comment #7
YesCT CreditAttribution: YesCT commented#2: xmlrpc-guzzle-1862512-2.patch queued for re-testing.
Comment #8
mitron CreditAttribution: mitron commentedThis patch changes the xmlrpc api. Is that what is intended? There are no calls or tests currently in core that depend on the current api so the tests will not show any problems with this api change. Do we care if anything is being broken in contrib?
Comment #9
BerdirWe don't care, API changes can still happen.
Comment #10
BerdirRe-roll, using the improved exceptions and Drupal::httpClient().
The XML-RPC library needs quite a bit of work but I'm trying to keep the patch size down. But the whole thing should probably be a service and get the http client injected, throw exception and stuff like that.
Comment #11
YesCT CreditAttribution: YesCT commenteddo we want to type hint array in the function definition?
like:
function _xmlrpc($url, array $args, array $headers = array())
otherwise, standards-wise this looks good.
Comment #12
BerdirSure, can do that :)
Comment #13
YesCT CreditAttribution: YesCT commentedrelated: #1158720: Improve text for parameter type hinting in function declaration
here is the patch to add the type hinting.
Comment #15
BerdirInvalid values generate a list of form errors. Other EntityTranslationUITest.php 40 Drupal\translation_entity\Tests\EntityTranslationUITest->testTranslationUI()
Seen that one a lot recently, in various translation UI tests. How can @plach write that many randomly failing tests ;)
Needs an issue.
Comment #16
Berdir#13: xml-rpc-guzzle-1875614-13.patch queued for re-testing.
Comment #17
YesCT CreditAttribution: YesCT commentedHere is the new issue:
#1965048: Frequent random test failure EntityTranslationUITest Invalid values generate a list of form errors.
for #15.
Comment #18
tstoecklerLooks like a pretty straight conversion.
Comment #19
BerdirThanks. There is one small API change here, instead of allowing arbitrary drupal_http_request() options, we just accept an array of headers now. So that will need a small change notice but I have no idea if anyone out there is actually using that :)
Comment #20
alexpottCommitted a51bb7e and pushed to 8.x. Thanks!
Comment #21
BerdirCreated http://drupal.org/node/1968052
Comment #22
BerdirAnd removing tag. I could swear I did that above.