Follow-up of #1026616: Implement an entity render controller.

TermRenderController currently does is this:

    // TODO: rename "term" to "taxonomy_term" in theme_taxonomy_term().
    $return['#term'] = $return["#{$this->entityType}"];
    unset($return["#{$this->entityType}"]);

As suggested in the @todo, let's rename the default theme function (template?) so that we can remove the unecessary override of this method.

Related to #1857324: Use default theme name and entity key in $build for user entity

CommentFileSizeAuthor
#25 drupal_1857336_25.patch2.68 KBXano
#22 drupal_1857336_22.patch2.64 KBXano
#20 taxonomy-term-key-1857336-20.patch2.54 KBInternetDevels
#10 1857336-9.patch2.54 KBBerdir
#7 1857336-7.patch2.49 KBswentel
#7 interdiff.txt619 bytesswentel
#5 1857336-5.patch2.09 KBswentel
#1 taxonomy-term-key-1857336-1.patch1.65 KBBerdir
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Active » Needs review
FileSize
taxonomy-term-key-1857336-1.patch1.65 KB

Looks like this is all...

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Issue tags: -Entity system

#1: taxonomy-term-key-1857336-1.patch queued for re-testing.

swentel’s picture

swentel CreditAttribution: swentel commented

#1: taxonomy-term-key-1857336-1.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Entity system

The last submitted patch, taxonomy-term-key-1857336-1.patch, failed testing.

swentel’s picture

swentel CreditAttribution: swentel commented
Status: Needs work » Reviewed & tested by the community
FileSize
1857336-5.patch2.09 KB

reroll + one doc update.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1857336-5.patch, failed testing.

swentel’s picture

swentel CreditAttribution: swentel commented
Status: Needs work » Needs review
FileSize
interdiff.txt619 bytes
1857336-7.patch2.49 KB

Urgh

areke’s picture

areke CreditAttribution: areke commented
Issue summary: View changes
Status: Needs review » Needs work
Issue tags: +Needs reroll

It looks like this needs a re-roll.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Needs work » Needs review

Re-roll.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
FileSize
1857336-9.patch2.54 KB

Now with the patch.

Status: Needs review » Needs work

The last submitted patch, 10: 1857336-9.patch, failed testing.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Needs work » Needs review

10: 1857336-9.patch queued for re-testing.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Entity system, -Needs reroll +Entity Field API

Still the same patch that was RTBC'd before. It's a tiny API change, but without it, we need to make #2023571: Support preprocessing in EntityViewBuilder more complicated as it needs to account for this special case.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented

10: 1857336-9.patch queued for re-testing.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 10: 1857336-9.patch, failed testing.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Needs work » Needs review

10: 1857336-9.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 10: 1857336-9.patch, failed testing.

swentel’s picture

swentel CreditAttribution: swentel commented
Status: Needs work » Needs review

10: 1857336-9.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 10: 1857336-9.patch, failed testing.

InternetDevels’s picture

InternetDevels CreditAttribution: InternetDevels commented
Status: Needs work » Needs review
FileSize
taxonomy-term-key-1857336-20.patch2.54 KB

Patch attached.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Needs review » Reviewed & tested by the community

Thanks, back to RTBC.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Status: Reviewed & tested by the community » Needs review
FileSize
drupal_1857336_22.patch2.64 KB

Re-roll.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Reviewed & tested by the community

Oh yes please...

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll 
error: patch failed: core/modules/taxonomy/taxonomy.module:386
error: core/modules/taxonomy/taxonomy.module: patch does not apply
Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Status: Needs work » Needs review
FileSize
drupal_1857336_25.patch2.68 KB

Re-roll.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs reroll

Crazy how often such a small patch can conflict. RTBC if bot agrees.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 25: drupal_1857336_25.patch, failed testing.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Needs work » Needs review

25: drupal_1857336_25.patch queued for re-testing.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Needs review » Reviewed & tested by the community

Trying again.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 57aaddb and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.