Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Follow-up of #1026616: Implement an entity render controller.
TermRenderController currently does is this:
// TODO: rename "term" to "taxonomy_term" in theme_taxonomy_term().
$return['#term'] = $return["#{$this->entityType}"];
unset($return["#{$this->entityType}"]);
As suggested in the @todo, let's rename the default theme function (template?) so that we can remove the unecessary override of this method.
Related to #1857324: Use default theme name and entity key in $build for user entity
Comment | File | Size | Author |
---|---|---|---|
#25 | drupal_1857336_25.patch | 2.68 KB | Xano |
Comments
Comment #1
BerdirLooks like this is all...
Comment #2
Berdir#1: taxonomy-term-key-1857336-1.patch queued for re-testing.
Comment #3
swentel CreditAttribution: swentel commented#1: taxonomy-term-key-1857336-1.patch queued for re-testing.
Comment #5
swentel CreditAttribution: swentel commentedreroll + one doc update.
Comment #7
swentel CreditAttribution: swentel commentedUrgh
Comment #8
areke CreditAttribution: areke commentedIt looks like this needs a re-roll.
Comment #9
BerdirRe-roll.
Comment #10
BerdirNow with the patch.
Comment #12
Berdir10: 1857336-9.patch queued for re-testing.
Comment #13
BerdirStill the same patch that was RTBC'd before. It's a tiny API change, but without it, we need to make #2023571: Support preprocessing in EntityViewBuilder more complicated as it needs to account for this special case.
Comment #14
xjm10: 1857336-9.patch queued for re-testing.
Comment #16
Berdir10: 1857336-9.patch queued for re-testing.
Comment #18
swentel CreditAttribution: swentel commented10: 1857336-9.patch queued for re-testing.
Comment #20
InternetDevels CreditAttribution: InternetDevels commentedPatch attached.
Comment #21
BerdirThanks, back to RTBC.
Comment #22
XanoRe-roll.
Comment #23
aspilicious CreditAttribution: aspilicious commentedOh yes please...
Comment #24
alexpottComment #25
XanoRe-roll.
Comment #26
BerdirCrazy how often such a small patch can conflict. RTBC if bot agrees.
Comment #28
Berdir25: drupal_1857336_25.patch queued for re-testing.
Comment #29
BerdirTrying again.
Comment #30
alexpottCommitted 57aaddb and pushed to 8.x. Thanks!