If pictures are enabled, the user edit page has two additional options: one to delete the current picture and one to upload a replacement picture. The delete option should only be shown if a picture already exists; if not the option is useless. This patch fixes this functionality.

CommentFileSizeAuthor
delete_picture.patch910 bytesChrisKennedy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

m1mic’s picture

m1mic CreditAttribution: m1mic commented
Status: Needs review » Reviewed & tested by the community

Tested with:

  • DRUPAL-6-0-BETA-2
  • PHP 5.2.1
  • Apache 2.0.59 (MAMP)

Patch works as advertised. Marking as RTBC.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Reviewed & tested by the community » Fixed

Agreed, committed. The previous code was dependent on the theme function returning an empty string if there is no picture, but this might not be the case if for example you have a default picture or would otherwise return a placeholder anyway if there is no picture.

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.